garbage outputted in console? #8497

jackTabsCode · 2024-02-27T16:54:41Z

Check for existing issues

Completed

Describe the bug / provide steps to reproduce it

I'm having an issue with some commands where, what I believe to be are color codes are being spat into the output.
This issue is not occurring with the built in Terminal.

I'm not 100% sure if this is due to Zed so I think this might need some further investigation, but I'm assuming it might be because of it being a non issue with other terminals?

Environment

Zed: v0.124.6 (Zed Preview)
OS: macOS 14.3.1
Memory: 32 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

If applicable, attach your `~/Library/Logs/Zed/Zed.log` file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

The text was updated successfully, but these errors were encountered:

Moshyfawn · 2024-02-28T03:17:26Z

Looks like an escape sequence representing cursor movement 🤔

jackTabsCode · 2024-02-28T03:22:19Z

Looks like an escape sequence representing cursor movement 🤔

Interesting. I don't know much about this kind of stuff. I edited the issue title.

izuzak · 2024-04-09T06:13:33Z

I'm seeing the same and was about to open a new issue when I found this one.

To reproduce:

Start Zed and open the terminal with an empty settings.json file
Run git log -n 5 --pretty=format:'%C(red)%h' --date=short
Notice the strange sequence of characters near the start of the output (:c8c8/cccc/d4d4^G^[]11;rgb:3b3b/4141/4d4d^G) and after the command runs (10;rgb:c8c8/cccc/d4d411;rgb:3b3b/4141/4d4d). They look like some form of color information or escape sequences.

Observed:

Expected (and what Alacritty shows):

Zed info:

Zed: v0.130.2 (Zed Preview)
OS: macOS 14.4.1
Memory: 64 GiB
Architecture: aarch64

jackTabsCode · 2024-04-09T07:10:04Z

Here's another repro, running gh repo view:

tolluset · 2024-06-24T03:49:14Z

Same problem occurred. Even not showing git diff.

❯ git diff
❯ 10;rgb:c8c8/cccc/d4d4
❯ 11;rgb:3b3b/4141/4d4d

SomeoneToIgnore · 2024-06-24T08:23:19Z

For anyone having these symptoms and having delta installed for git diff browsing, #13418 (comment) might help.
Relevant delta issue: dandavison/delta#1707

izuzak · 2024-06-24T08:38:29Z

For anyone having these symptoms and having delta installed for git diff browsing, #13418 (comment) might help. Relevant delta issue: dandavison/delta#1707

This didn't help me, unfortunately, but completely removing delta from my .gitconfig did help. 🤷 So, definitely seems like a problem related to using delta. 👍 Thanks for pointing to this out, @SomeoneToIgnore ⚡

EDIT: ohh, actually what helped was adding --dark and removing export GIT_PAGER=delta from my .bashrc. 🎉

tolluset · 2024-06-25T11:51:33Z

For anyone having these symptoms and having delta installed for git diff browsing, #13418 (comment) might help. Relevant delta issue: dandavison/delta#1707

Thanks! It works for me!

jackTabsCode · 2024-06-25T16:45:43Z

Do these fixes suggested only apply to git diff?

I'm confused on why this is happening. I don't know a lot about terminal emulators. How is it possible that something can put text in the input field? And why would it be a color code?

sssilvar · 2024-07-04T07:57:52Z

Do these fixes suggested only apply to git diff?

I'm confused on why this is happening. I don't know a lot about terminal emulators. How is it possible that something can put text in the input field? And why would it be a color code?

No, seems to be happenin with other CLI tools (e.g., #9742)

silvenon · 2024-07-04T10:13:38Z

For me this happens with lefthook. Especially annoying on its pre-commit hook because I have nvim as my git editor.

bash · 2024-07-13T13:17:01Z

Hi, author of terminal-colorsaurus (the library that delta uses for color detection) here 👋🏼

The 10;rgb:c8c8/cccc/d4d4 11;rgb:3b3b/4141/4d4d output is caused by delta trying to detect the terminal's foreground and background color. To do this it uses terminal-colorsaurus.

The output appears because terminal-colorsaurus thinks that zed doesn't support these sequences. It uses a neat trick to detect support. This trick relies on the fact that terminals usually answer to different queries in the order that they arrived.

Zed however replies to color queries out of order.

For example when sending OSC 11 ; ? ST (bg color query) followed by CSI c (request device attributes) the response to CSI c arrives first:

$ printf '\e]11;?\e\\ \e[c' && cat -v
 ^[[?6c^[]11;rgb:dcdc/dcdc/dddd^[\^C

(edit: my printf was incorrect, but my conclusion was nevertheless correct ^^)

ttys3 · 2024-07-23T10:43:43Z

delta user, and use delta as git diff tool.

I got this too.

]10;rgb:c8c8/cccc/d4d4

11;rgb:3b3b/4141/4d4d

Partially addresses #8497 (namely, the occurring with `delta`) As I mentioned in #8497 (comment), zed currently replies to OSC color requests (`OSC 10`, `OSC 11`, ...) out of order when immediately followed by another request (for example `CSI c`). All other terminals that [I have tested](https://github.com/bash/terminal-colorsaurus/blob/main/doc/terminal-survey.md) maintain relative order when replying to requests. ## Solution Respond to the `ColorRequest` in `process_event` (in the same place where other PTY writes happen) instead of queuing it up in the internal event queue. ## Alternative I initially thought that I could handle the color request similarly to the `TextAreaSizeRequest` where the size is stored in `last_content` and updated on `sync`. However this causes the terminal to report out-of-date values when a "set color" sequence is followed by a color request. ## Tests 1. `OSC 11; ?` (request bg color) + `CSI c` (request device attributes): ```shell printf '\e]11;?\e\\ \e[c' && cat -v # Expected result: ^[]11;rgb:dcdc/dcdc/dddd^[\^[[?6c # Current result: ^[[?6c^[]11;rgb:dcdc/dcdc/dddd^[\ (❌) # Result with this PR: ^[]11;rgb:dcdc/dcdc/dddd^[\^[[?6c (✅) # Result with alternative: ^[]11;rgb:dcdc/dcdc/dddd^[\^[[?6c (✅) ``` 2. `OSC 11; rgb:f0f0/f0f0/f0f0` (set bg color) + `OSC 11; ?` (request bg color) ```shell printf '\e]11;rgb:f0f0/f0f0/f0f0\e\\ \e]11;?\e\\' && cat -v # Expected result: ^[]11;rgb:f0f0/f0f0/f0f0^[\ # Current result: ^[]11;rgb:f0f0/f0f0/f0f0^[\ (✅) # Result with this PR: ^[]11;rgb:f0f0/f0f0/f0f0^[\ (✅) # Result with alternative: ^[]11;rgb:OUT_OF_DATE_COLOR_HERE^[\ (❌) ``` Release Notes: - N/A

brandonweiss · 2024-08-22T17:10:20Z

This is also happening for me on repos that use lefthook.

mgoodness · 2024-08-27T17:10:24Z

Fingers crossed for #15105 (comment) to be true.

brandonweiss · 2024-08-28T18:10:26Z

I also was able to fix it by just updating Lefthook, so it must be some weird combination of two issues?

yodatak · 2024-08-29T10:58:43Z

for me its fix in v0.151.0-pre

silvenon · 2024-10-29T23:28:45Z

FWIW I no longer seem to be experiencing this issue, I also think the fix might have been two-fold, both a Zed update and a Lefthook update.

jackTabsCode · 2024-10-30T05:44:19Z

I'm still experiencing this issue, but not with Lefthook. I just had it happen the other day, but I can't remember what program it was. I'll report back once I find out

notpeter · 2025-01-02T15:24:01Z

I am no longer able to reproduce this issue.

If you are seeing this with a current version of Zed please reply with your zed version and steps to reproduce and I'm happy to reopen.

Thanks all!

jackTabsCode added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Feb 27, 2024

Moshyfawn added terminal Feedback for terminal integration, shell commands, etc and removed triage Maintainer needs to classify the issue labels Feb 28, 2024

jackTabsCode changed the title ~~Leftover colors outputted in console?~~ garbage outputted in console? Feb 28, 2024

JosephTLyons removed the admin read Pending admin review label Feb 28, 2024

github-actions bot mentioned this issue Mar 5, 2024

Top-Ranking Issues (last 7 days) 📊 #6952

Open

SomeoneToIgnore mentioned this issue Apr 20, 2024

Color escape sequences dumped in the terminal #10804

Closed

1 task

roehnan mentioned this issue Jul 28, 2024

On linux opening terminal echo some rgb color #15105

Closed

1 task

bash mentioned this issue Aug 19, 2024

terminal: Retain relative order of responses #16456

Merged

SomeoneToIgnore mentioned this issue Aug 31, 2024

When starting the terminal, some garbled characters appear. #17194

Closed

1 task

notpeter closed this as completed Jan 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

garbage outputted in console? #8497

garbage outputted in console? #8497

jackTabsCode commented Feb 27, 2024

Moshyfawn commented Feb 28, 2024

jackTabsCode commented Feb 28, 2024

izuzak commented Apr 9, 2024

jackTabsCode commented Apr 9, 2024

tolluset commented Jun 24, 2024

SomeoneToIgnore commented Jun 24, 2024

izuzak commented Jun 24, 2024 •

edited

Loading

tolluset commented Jun 25, 2024

jackTabsCode commented Jun 25, 2024

sssilvar commented Jul 4, 2024

silvenon commented Jul 4, 2024

bash commented Jul 13, 2024 •

edited

Loading

ttys3 commented Jul 23, 2024 •

edited

Loading

brandonweiss commented Aug 22, 2024

mgoodness commented Aug 27, 2024

brandonweiss commented Aug 28, 2024

yodatak commented Aug 29, 2024

silvenon commented Oct 29, 2024 •

edited

Loading

jackTabsCode commented Oct 30, 2024

notpeter commented Jan 2, 2025

garbage outputted in console? #8497

garbage outputted in console? #8497

Comments

jackTabsCode commented Feb 27, 2024

Check for existing issues

Describe the bug / provide steps to reproduce it

Environment

If applicable, add mockups / screenshots to help explain present your vision of the feature

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

Moshyfawn commented Feb 28, 2024

jackTabsCode commented Feb 28, 2024

izuzak commented Apr 9, 2024

jackTabsCode commented Apr 9, 2024

tolluset commented Jun 24, 2024

SomeoneToIgnore commented Jun 24, 2024

izuzak commented Jun 24, 2024 • edited Loading

tolluset commented Jun 25, 2024

jackTabsCode commented Jun 25, 2024

sssilvar commented Jul 4, 2024

silvenon commented Jul 4, 2024

bash commented Jul 13, 2024 • edited Loading

ttys3 commented Jul 23, 2024 • edited Loading

brandonweiss commented Aug 22, 2024

mgoodness commented Aug 27, 2024

brandonweiss commented Aug 28, 2024

yodatak commented Aug 29, 2024

silvenon commented Oct 29, 2024 • edited Loading

jackTabsCode commented Oct 30, 2024

notpeter commented Jan 2, 2025

If applicable, attach your `~/Library/Logs/Zed/Zed.log` file to this issue.

izuzak commented Jun 24, 2024 •

edited

Loading

bash commented Jul 13, 2024 •

edited

Loading

ttys3 commented Jul 23, 2024 •

edited

Loading

silvenon commented Oct 29, 2024 •

edited

Loading