Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digitally sign DMG file too #8671

Closed
1 task done
asesh opened this issue Mar 1, 2024 · 6 comments
Closed
1 task done

Digitally sign DMG file too #8671

asesh opened this issue Mar 1, 2024 · 6 comments
Labels
enhancement [core label] installer / updater Feedback for installation and update process macOS Platform-specific feedback for macOS behaviors, features, design, etc

Comments

@asesh
Copy link

asesh commented Mar 1, 2024

Check for existing issues

  • Completed

Describe the feature

It looks like the files inside DMG files are digitally signed but the the main disk image file is not digitally signed at all. Is there any reason to do so? It would be appreciated if the main disk image file was digitally signed too, to ensure the files are intact and the publisher's information can be found out from the disk image too.

Why it's important?

Certain companies have policies which will only allow the use of digitally signed DMG/PEs only.

Lastly, thank you so much for creating such an awesome product and making it open source too.

If applicable, add mockups / screenshots to help present your vision of the feature

No response

@asesh asesh added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Mar 1, 2024
@asesh asesh changed the title Please digitally sign DMG file too Digitally sign DMG file too Mar 1, 2024
@SomeoneToIgnore
Copy link
Contributor

Could be related to #6205 (comment) cc @mrnugget

@asesh
Copy link
Author

asesh commented Mar 1, 2024

Could be related to #6205 (comment) cc @mrnugget

Looks like it's not related. The app is digitally signed, I am talking about the DMG file which is not digitally signed at all.

@Moshyfawn Moshyfawn added installer / updater Feedback for installation and update process and removed triage Maintainer needs to classify the issue labels Mar 2, 2024
@JosephTLyons JosephTLyons added macOS Platform-specific feedback for macOS behaviors, features, design, etc and removed admin read Pending admin review labels Mar 5, 2024
osiewicz added a commit that referenced this issue Mar 15, 2024
Related: #6837, #8671 
Release Notes:

- Zed now ships as a non-universal binary, reducing binary size by ~50%.
@osiewicz
Copy link
Contributor

osiewicz commented Mar 15, 2024

That's done as of #9284; I've checked it locally but just in case anybody wanted to double-check, signed artifacts are available in e.g: https://github.com/zed-industries/zed/actions/runs/8297127089

@asesh
Copy link
Author

asesh commented Mar 16, 2024

That's done as of #9284; I've checked it locally but just in case anybody wanted to double-check, signed artifacts are available in e.g: https://github.com/zed-industries/zed/actions/runs/8297127089

@osiewicz Thank you so much 🙇. Besides the link you posted above, I just went to zed.dev to download it, looks like it's still not available as production build for all the users.

@osiewicz
Copy link
Contributor

osiewicz commented Mar 16, 2024

Ah yeah, we don't have an official stable/preview build yet; that'll be available this Wednesday most likely.

@asesh
Copy link
Author

asesh commented Mar 28, 2024

@osiewicz Thank you so much again. Zed's stable version now ships with ARM64 only build and it's digitally signed too 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [core label] installer / updater Feedback for installation and update process macOS Platform-specific feedback for macOS behaviors, features, design, etc
Projects
None yet
Development

No branches or pull requests

5 participants