Improve ssh remote error handling and logging #15035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
maxbrunsfeld
commented
Jul 23, 2024
| AddWorktree add_worktree = 500; | ||
| AddWorktreeResponse add_worktree_response = 501; | ||
| AddWorktree add_worktree = 222; | ||
| AddWorktreeResponse add_worktree_response = 223; // current max |
There was a problem hiding this comment.
This PR renumbers two protobufs that are only for the work-in-progress SSH remoting feature. These aren't used for collab. When these messages landed on main, I accidentally left them with temporary numbers which I had initially used to avoid merge conflicts. This is just making them use consistent numbering. I'm landing it before the SSH stuff goes out to preview.
CharlesChen0823
pushed a commit
to CharlesChen0823/zed
that referenced
this pull request
Jul 29, 2024
Release Notes: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes: