Add instruction for metal to Getting Started #16820
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpui requires "metal", but it's not installed on a new system. The fix comes from gfx-rs/gfx#2309 (comment)
|
We require contributors to sign our Contributor License Agreement, and we don't have @kevinbader on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
maxdeviant
reviewed
Aug 25, 2024
| @@ -5,7 +5,9 @@ for Rust, designed to support a wide variety of applications. | |||
|
|
|||
| ## Getting Started | |||
|
|
|||
| GPUI is still in active development as we work on the Zed code editor and isn't yet on crates.io. You'll also need to use the latest version of stable rust and be on macOS. Add the following to your Cargo.toml: | |||
| GPUI is still in active development as we work on the Zed code editor and isn't yet on crates.io. You'll also need to use the latest version of stable rust and be on macOS. If `xcrun metal` is _unable to find utility "metal"_, install `xcode` and run `sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer`. | |||
There was a problem hiding this comment.
Can we put this down below, as it is essentially a troubleshooting step?
I don’t think it reads well in this paragraph.
|
Thanks for the PR. I'm going to close in favor of #17316. |
maxdeviant
added a commit
that referenced
this pull request
Sep 3, 2024
This PR updates the GPUI docs to mention how to install XCode for Metal support. Supersedes #16820. Release Notes: - N/A
osiewicz
pushed a commit
to CharlesChen0823/zed
that referenced
this pull request
Sep 5, 2024
…#17316) This PR updates the GPUI docs to mention how to install XCode for Metal support. Supersedes zed-industries#16820. Release Notes: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gpui requires "metal", but it's not installed on a new system. The instruction should resolve a stumbling block for other newcomers like me, and comes from gfx-rs/gfx#2309 (comment)