Improve popup menu to leave some margin with window edges #17159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
huacnlee
commented
Aug 30, 2024
| @@ -60,6 +60,12 @@ impl Anchored { | |||
| self.fit_mode = AnchoredFitMode::SnapToWindow; | |||
| self | |||
| } | |||
|
|
|||
| /// Snap to window edge and leave some margins. | |||
| pub fn snap_to_window_with_margin(mut self, edges: impl Into<Edges<Pixels>>) -> Self { | |||
There was a problem hiding this comment.
I am not sure if this is the best name, I have considered changing the snap_to_window to add an argument, but sometimes the edge may not a must.
|
Thanks! |
huacnlee
added a commit
to longbridgeapp/gpui-component
that referenced
this pull request
Sep 7, 2024
- Also update GPUI. Ref: zed-industries/zed#17159 <img width="866" alt="image" src="https://github.com/user-attachments/assets/0737e4e4-7069-4554-a766-b9fc7b487fd6">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
Updates in GPUI
snap_to_window_with_marginmethod toanchoredto support leave margin to window edges.Before
After