Make Vim movement to end of line configurable

[svelterust]

Release Notes:

• Add ability to configure Vim movement when moving to the right

[cla-bot]

We require contributors to sign our Contributor License Agreement, and we don't have @knarkzel on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

[svelterust]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[svelterust]

I want to make it possible to configure normal mode and visual mode movement:

• "vim_normal_include_newline": boolean
• "vim_visual_include_newline": boolean

If it's true, it uses clip_ignoring_line_ends, otherwise clip_point. How can I do that?

[svelterust]

Same with mouse

[SomeoneToIgnore]

There's been a need to do similar things for #16848 and we ended up with defining fields in the actions to modify this behavior.

This is the 2nd case in out Vim support where line ends matter, so maybe we can still do a similar thing.
If there's an entire class of things to change, maybe we can consider adding it into global settings, but would be good to know first.

[svelterust]

It's following I have noticed:

• Mouse clicking on end of line doesn't go to newline, annoying.
• Right doesn't go to newline in normal mode. In visual mode it does, so when deleting the newline is included (annoying).
• End of line doesn't go to newline in normal mode. In visual mode it does, so when deleting the newline is included (annoying)

[svelterust]

Essentially it's something that should be configurable, like "include_newline" on per command basis. Then this can be modified for normal mode and visual mode.

[ConradIrwin]

@knarkzel I think if we want to do this we should just have a setting on the vim crate for allow_cursor_beyond_line_end which defaults to false. If that setting is set, we would always return false from

zed/crates/vim/src/vim.rs

Line 573 in f3b5894

pub fn clip_at_line_ends(&self) -> bool {

.

That said, I am nervous about this because while I don't like the existing clip_at_line_ends stuff, it does replicate what vim does (and I don't want to test new features with this setting enabled, so it will likely have strange edge-cases).

Why do you want to be able to do this?

[ConradIrwin]

Closing this for now, but let me know if you're still interested in this.