New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `Buffer::apply_ops` infallible #18089

Merged

maxdeviant merged 2 commits into main from marshall/make-buffer-apply-ops-infallible

Sep 19, 2024

+85 −108

Member

maxdeviant commented Sep 19, 2024

This PR makes the Buffer::apply_ops method infallible for text::Buffer and language::Buffer.

We discovered that text::Buffer::apply_ops was only fallible due to apply_undo, which didn't actually need to be fallible.

Release Notes:

N/A


Make Buffer::apply_ops infallible

c8fb312

maxdeviant self-assigned this

cla-bot bot added the cla-signed label


Fix Clippy warning

cd162e8

maxdeviant merged commit 1fc391f into main

9 checks passed

maxdeviant deleted the marshall/make-buffer-apply-ops-infallible branch

September 19, 2024 17:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment