client: Send telemetry events with Content-Type: application/json
#18886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
maxdeviant
deleted the
marshall/send-telemetry-events-as-application-json
branch
|
Alternative take with less abstraction: #18890 |
KevinNitroG
pushed a commit
to KevinNitroG/zed
that referenced
this pull request
Oct 9, 2024
…ed-industries#18886) This PR updates the telemetry events sent to collab to use `Content-Type: application/json` instead of `Content-Type: text/plain`. The POST bodies are JSON, so `application/json` is the correct MIME type. I suspect the `text/plain` is a remnant from when the events were still going through Vercel. Release Notes: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the telemetry events sent to collab to use
Content-Type: application/jsoninstead ofContent-Type: text/plain.The POST bodies are JSON, so
application/jsonis the correct MIME type.I suspect the
text/plainis a remnant from when the events were still going through Vercel.Release Notes: