gpui: Fix SVG color render, when color have alpha #20537
+30
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
huacnlee
changed the title
huacnlee
commented
Nov 12, 2024
| @@ -116,6 +116,7 @@ env_logger.workspace = true | |||
| rand.workspace = true | |||
| util = { workspace = true, features = ["test-support"] } | |||
| http_client = { workspace = true, features = ["test-support"] } | |||
| reqwest_client = { workspace = true } | |||
There was a problem hiding this comment.
I have to add this to gpui example, to let remote image works.
huacnlee
commented
Nov 12, 2024
| pixel[0] = (pixel[0] as f32 / a) as u8; | ||
| pixel[1] = (pixel[1] as f32 / a) as u8; | ||
| pixel[2] = (pixel[2] as f32 / a) as u8; | ||
| swap_rgba_pa_to_bgra(pixel); |
There was a problem hiding this comment.
Here is extracted this code into swap_rgba_pa_to_bgra method to color.rs and fix divide 0 issue.
Co-authored-by: Floyd Wang <gassnake999@gmail.com>
huacnlee
force-pushed
the
fix-svg-alpha-color
branch
from
41e789f
to
fedbf4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
Demo