Skip to content

vim: Fix the goto definition action in vim where it goes into visual mode #42705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

vim: Fix the goto definition action in vim where it goes into visual mode #42705

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dc79aa
fixes the goto definition in vim where it goes into visual mode
shaik-zeeshan Nov 14, 2025
679c36c
refactor(editor): collapse range when vim mode is enabled
dinocosta Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion crates/editor/src/editor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16207,6 +16207,7 @@ impl Editor {
let Some(end) = multibuffer.buffer_point_to_anchor(&buffer, range.end, cx) else {
return;
};

self.change_selections(
SelectionEffects::default().nav_history(true),
window,
Expand Down Expand Up @@ -16921,7 +16922,15 @@ impl Editor {

editor.update_in(cx, |editor, window, cx| {
let range = target_range.to_point(target_buffer.read(cx));
let range = editor.range_for_match(&range, false);

// When vim mode is enabled, ensure that the range is
// collapsed to the range's start point, otherwise actions
// like jumping to a function's definition in vim mode would
// change the mode to Visual.
let range = match vim_flavor(cx) {
Some(_) => editor.range_for_match(&range, true),
None => editor.range_for_match(&range, false),
};
let range = collapse_multiline_range(range);

if !split
Expand Down
Loading