Fix the handling of softlinked config and other watched files #42854
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watcher is using to make sure that both OS events and given paths are able to match.
cla-bot
bot
added
the
cla-signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have softlinked my config to my dotfiles (it actually passes through 2 softlinks) which resulted in an error
ignoring event <path> outside of root path <another path>an in inconsistent behavior of the config menu (sometimes I need to toggle a config multiple times or the config UI changes do not work at all)The fix:
Canonicalize the provided path that the event processor of the worktree watcher is using to make sure that both OS events and given paths are able to match.
Release Notes: