Fix persistence of low severity diagnostics #42887
Open
+37
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
smpanaro
commented
Nov 17, 2025
| let new_summary = DiagnosticSummary::new(&diagnostics); | ||
| if new_summary.is_empty() { | ||
| if diagnostics.is_empty() { | ||
| if let Some(diagnostics_by_server_id) = diagnostics_for_tree.get_mut(&path_in_worktree) |
Author
There was a problem hiding this comment.
One unrelated thing I noticed but wasn't sure about was that in this branch summaries_by_server_id.insert isn't updated. It doesn't seem to matter for this particular issue so left it as is.
This comment was marked as outdated.
This comment was marked as outdated.
Author
|
Seems this broke a couple tests, which I've fixed. I think it also exposed a different issue for non-open files, those without a buffer, where a streaming workspace diagnostic pull would discard previously pushed diagnostics (as opposed to the the non-streaming case where they are kept). I think that behavior makes sense to me so applied it, but willing to change it. I left one TODO on some code that felt a little duplicative, may circle back but might also wait for PR feedback :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41935
It seems the issue was not related to the tag, but instead caused when all the diagnostics for a file are
DiagnosticSeverityHintand/orInformation. In that case they are cleared because the summary only includesWarningandError.I tested this following the steps in the issue for the local case, and updated some existing tests for the remote/collab case.
Release Notes: