project search: Skip loading of gitignored paths when their descendants will never match an inclusion/exclusion query #42968
+276
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
will never match an inclusion/exclusion query. Co-authored-by: dino <dinojoaocosta@gmail.com>
osiewicz
force-pushed
the
project-search-bail-on-gitignored-directories-earlier
branch
from
e271410 to
6915601
Compare
osiewicz
changed the title
osiewicz
commented
Nov 18, 2025
smitbarmase
approved these changes
Nov 18, 2025
Contributor
Author
|
Our tests found an issue with a scenario where we have:
Exclusion pattern will prune files before we even get to loading the |
osiewicz
commented
Nov 18, 2025
Contributor
Author
There was a problem hiding this comment.
IMHO these tests could reside in project_search.rs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: dino dinojoaocosta@gmail.com
Related-to: #38799
Release Notes: