Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/editor/src/editor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6722,6 +6722,9 @@ impl Editor {
return;
};

if self.blame.is_none() {
self.start_git_blame(true, window, cx);
}
let Some(blame) = self.blame.as_ref() else {
return;
};
Expand Down
66 changes: 47 additions & 19 deletions crates/editor/src/element.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1219,7 +1219,13 @@ impl EditorElement {
editor.hide_blame_popover(false, cx);
}
} else {
editor.hide_blame_popover(false, cx);
let keyboard_grace = editor
.inline_blame_popover
.as_ref()
.is_some_and(|state| state.keyboard_grace);
if !keyboard_grace {
editor.hide_blame_popover(false, cx);
}
}

let breakpoint_indicator = if gutter_hovered {
Expand Down Expand Up @@ -2503,7 +2509,6 @@ impl EditorElement {
scroll_position: gpui::Point<ScrollOffset>,
scroll_pixel_position: gpui::Point<ScrollPixelOffset>,
line_height: Pixels,
text_hitbox: &Hitbox,
window: &mut Window,
cx: &mut App,
) -> Option<InlineBlameLayout> {
Expand Down Expand Up @@ -2572,16 +2577,6 @@ impl EditorElement {
let size = element.layout_as_root(AvailableSpace::min_size(), window, cx);
let bounds = Bounds::new(absolute_offset, size);

self.layout_blame_entry_popover(
entry.clone(),
blame,
line_height,
text_hitbox,
row_info.buffer_id?,
window,
cx,
);

element.prepaint_as_root(absolute_offset, AvailableSpace::min_size(), window, cx);

Some(InlineBlameLayout {
Expand All @@ -2592,16 +2587,48 @@ impl EditorElement {
})
}

fn layout_blame_entry_popover(
fn layout_blame_popover(
&self,
blame_entry: BlameEntry,
blame: Entity<GitBlame>,
line_height: Pixels,
editor_snapshot: &EditorSnapshot,
text_hitbox: &Hitbox,
buffer: BufferId,
line_height: Pixels,
window: &mut Window,
cx: &mut App,
) {
if !self.editor.read(cx).inline_blame_popover.is_some() {
return;
}

let Some(blame) = self.editor.read(cx).blame.clone() else {
return;
};
let cursor_point = self
.editor
.read(cx)
.selections
.newest::<language::Point>(&editor_snapshot.display_snapshot)
.head();

let Some((buffer, buffer_point, _)) = editor_snapshot
.buffer_snapshot()
.point_to_buffer_point(cursor_point)
else {
return;
};

let row_info = RowInfo {
buffer_id: Some(buffer.remote_id()),
buffer_row: Some(buffer_point.row),
..Default::default()
};

let Some((buffer_id, blame_entry)) = blame
.update(cx, |blame, cx| blame.blame_for_rows(&[row_info], cx).next())
.flatten()
else {
return;
};

let Some((popover_state, target_point)) = self.editor.read_with(cx, |editor, _| {
editor
.inline_blame_popover
Expand All @@ -2623,7 +2650,7 @@ impl EditorElement {
popover_state.markdown,
workspace,
&blame,
buffer,
buffer_id,
window,
cx,
)
Expand Down Expand Up @@ -9672,7 +9699,6 @@ impl Element for EditorElement {
scroll_position,
scroll_pixel_position,
line_height,
&text_hitbox,
window,
cx,
) {
Expand Down Expand Up @@ -9870,6 +9896,8 @@ impl Element for EditorElement {
window,
cx,
);

self.layout_blame_popover(&snapshot, &hitbox, line_height, window, cx);
}

let mouse_context_menu = self.layout_mouse_context_menu(
Expand Down
Loading