editor: Fix tab tooltips not showing file path for remote files #43359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
wzulfikar
added a commit
to wzulfikar/zed
that referenced
this pull request
Nov 24, 2025
* language: Move language server update to background when it takes too long (zed-industries#43164) Closes zed-industries#42360 If updating a language server takes longer than 10 seconds, we now fall back to launching the currently installed version (if exists) and continue downloading the update in the background. Release Notes: - Improved language server updates for slow connection, now Zed launches existing server if the update is taking too long. --------- Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com> * Fix `connect.host` setting being ignored by debugpy (zed-industries#43190) Closes zed-industries#42727 Unfortunately we can only support IPv4 addresses right now because `TcpArguments` only supports an IPv4 address. I'm not sure how difficult it would be to lift this limitation. Release Notes: - Fixed `connect.host` setting being ignored by debugpy Co-authored-by: Cole Miller <cole@zed.dev> * Jetbrains keymap updates (zed-industries#42848) Closes zed-industries#14639 ## Release Notes: Various improvements to the Jetbrains keymap. Added various missing keyboard shortcuts that I use on a daily basis in Jetbrains, and changed a few which were present in the keymap but mapped to the wrong behavior. ### Added: - Added various missing keybindings for Jetbrains keymap - `ctrl-n` → `project_symbols::Toggle` - `ctrl-alt-n` → `file_finder::Toggle` (open project files) - `ctrl-~` → `git::Branch` - `ctrl-\` → `assistant::InlineAssist` - `ctrl-space` → `editor::ShowCompletions` - `ctrl-q` → `editor::Hover` - `ctrl-p` → `editor::ShowSignatureHelp` - `ctrl-f5` → `task::Rerun` - `shift-f9` → `debugger::Start` - `shift-f10` → `task::Spawn` - Added macOS equivalents for all of the above, however I only have a Linux machine so I have not tested the mac bindings. The binding are generally the same except `ctrl → cmd` with few exceptions. - `cmd-j` → `editor::Hover` ### Fixed: - Several incorrectly mapped keybindings for the Jetbrains keymap - `ctrl-alt-s` → `editor::OpenSettings` (was `editor::OpenSettingsFile`) - `ctrl-alt-b` → `editor::GoToImplementation` (was `editor::GoToDefinitionSplit`) - `alt-left` → `pane::ActivatePreviousItem` - `alt-right` → `pane::ActivateNextItem` - `ctrl-k` now opens the Git panel. I believe this was commented out because of a bug where focus is not given to the commit message text box, but imo the current behavior of not doing anything at all feels more confusing/frustrating to a Jetbrains user (projecting a little here, happy to revert). * Fix some panics (zed-industries#43233) Fixes ZED-2NP Fixes ZED-3DP Fixes ZED-3EV Release Notes: - N/A *or* Added/Fixed/Improved ... * zed: Allocate more rayon threads depending on available parallelism (zed-industries#43235) While zed itself is not a heavy user of rayon, wasmtime is, especially for compilation. This change is similar to the rayon default but we halve the number of threads still so we don't spawn too many threads overall. Release Notes: - N/A *or* Added/Fixed/Improved ... * docs: Fix small typo in docs for Snippets (zed-industries#43238) Happened to notice this typo while going through the docs. Release Notes: - N/A --- 💖 * docs: Point to the right URL for Gemini CLI (zed-industries#43239) Point to the right URL for Gemini CLI. Release Notes: - N/A --- 💖 * Allow onboarding pages to be zoomed in/out (zed-industries#43244) We were just missing adding keybindings for these. Release Notes: - onboarding: The onboarding pages can now be zoomed in/out with the same keybindings you'd use to zoom in/out a regular buffer. * agent_ui: Fix sent agent prompt getting lost after authentication (zed-industries#43245) Closes zed-industries#42379 Release Notes: - Fixed issue where a sent agent message is not restored after successful authentication. * Revert "util: Check whether discovered powershell is actually executable" (zed-industries#43247) Reverts zed-industries#43044 Closes zed-industries#43224 This slows down startup on windows significantly Release Notes: - Fixed slow startup on Windows * Fallible Settings (zed-industries#42938) Also tidies up error notifications so that in the case of syntax errors we don't see noise about the migration failing as well. Release Notes: - Invalid values in settings files will no longer prevent the rest of the file from being parsed. * Revert "gpui: Convert macOS clipboard file URLs to paths for paste" (zed-industries#43254) Reverts zed-industries#36848 Turns out this broke copying a screenshot from apps like CleanShot X and then pasting it over. We should land this again after taking a look at those cases. Pasting screenshots from the native macOS screenshot functionality works though. cc @seantimm Release Notes: - Fixed issue where copying a screenshot from apps like CleanShot X into Agent Panel didn't work as expected. * Fix install linux (zed-industries#43205) Closes: zed-industries#42726 Release Notes: - Fix ./script/install-linux for installing a development version of Zed on Linux * crashes: Print panic message to logs (zed-industries#43159) Release Notes: - N/A *or* Added/Fixed/Improved ... * zeta2: Predict at next diagnostic location (zed-industries#43257) When no predictions are available for the current buffer, we will now attempt to predict at the closest diagnostic from the cursor location that wasn't included in the last prediction request. This enables a commonly desired kind of far-away jump without requiring explicit model support. Release Notes: - N/A * markdown: Add LaTeX syntax highlighting injection (zed-industries#41110) Closes [zed-industries#30264](zed-industries#30264) Small addition based on [nvim-treesitter](https://github.com/nvim-treesitter/nvim-treesitter/blob/main/runtime/queries/markdown_inline/injections.scm) <img width="1122" height="356" alt="Screenshot From 2025-10-24 15-47-58" src="https://github.com/user-attachments/assets/33e7387d-a299-4921-9db8-622d2657bec1" /> This does require the LaTeX extension to be installed. Release Notes: - Added LaTeX highlighting for inline and display equations in Markdown when the LaTeX extension is installed --------- Co-authored-by: Ben Kunkle <ben@zed.dev> * agent_ui: Remove context strip from inline assistant (zed-industries#42633) TODO - [x] Implement PromptEditor::paste - [x] Fix creases on unlink - [x] PromptCompletionProviderDelegate::supports_images - [ ] Fix highlighting in completion menu Release Notes: - N/A --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com> * zeta2: Improve jump outside UI (zed-industries#43262) Still a prototype UI but a bit more noticeable :) Release Notes: - N/A * Make community champions public (zed-industries#43271) Release Notes: - N/A * terminal: New settings for path hyperlink regexes (zed-industries#40305) Closes: - zed-industries#12338 - zed-industries#40202 1. Adds two new settings which allow customizing the set of regexes used to identify path hyperlinks in terminal 1. Fixes path hyperlinks for paths containing unicode emoji and punctuation, for example, `mojo.🔥` 1. Fixes path hyperlinks for Windows verbatim paths, for example, `\\?\C:\Over\here.rs`. 1. Improves path hyperlink performance, especially for terminals with a lot of content 1. Replaces existing custom hard-coded default path hyperlink parsing logic with a set of customizable default regexes ## New settings (from default.json) ### terminal.path_hyperlink_regexes Regexes used to identify paths for hyperlink navigation. Supports optional named capture groups `path`, `line`, `column`, and `link`. If none of these are present, the entire match is the hyperlink target. If `path` is present, it is the hyperlink target, along with `line` and `column` if present. `link` may be used to customize what text in terminal is part of the hyperlink. If `link` is not present, the text of the entire match is used. If `line` and `column` are not present, the default built-in line and column suffix processing is used which parses `line:column` and `(line,column)` variants. The default value handles Python diagnostics and common path, line, column syntaxes. This can be extended or replaced to handle specific scenarios. For example, to enable support for hyperlinking paths which contain spaces in rust output, ``` [ "\\s+(-->|:::|at) (?<link>(?<path>.+?))(:$|$)", "\\s+(Compiling|Checking|Documenting) [^(]+\\((?<link>(?<path>.+))\\)" ], ``` could be used. Processing stops at the first regex with a match, even if no link is produced which is the case when the cursor is not over the hyperlinked text. For best performance it is recommended to order regexes from most common to least common. For readability and documentation, each regex may be an array of strings which are collected into one multi-line regex string for use in terminal path hyperlink detection. ### terminal.path_hyperlink_timeout_ms Timeout for hover and Cmd-click path hyperlink discovery in milliseconds. Specifying a timeout of `0` will disable path hyperlinking in terminal. ## Performance This PR fixes terminal to only search the hovered line for hyperlinks and adds a benchmark. Before this fix, hyperlink detection grows linearly with terminal content, with this fix it is proportional only to the hovered line. The gains come from replacing `visible_regex_match_iter`, which searched all visible lines, with code that only searches the line hovered on (including if the line is wrapped). Local benchmark timings (terminal with 500 lines of content): ||main|this PR|Δ| |-|-|-:|-| | cargo_hyperlink_benchmark | 1.4 ms | 13 µs | -99.0% | | rust_hyperlink_benchmark | 1.2 ms | 11 µs | -99.1% | | ls_hyperlink_benchmark | 1.3 ms | 7 µs | -99.5% | Release Notes: - terminal: New settings to allow customizing the set of regexes used to identify path hyperlinks in terminal - terminal: Fixed terminal path hyperlinks for paths containing unicode punctuation and emoji, e.g. mojo.🔥 - terminal: Fixed path hyperlinks for Windows verbatim paths, for example, `\\?\C:\Over\here.rs` - terminal: Improved terminal hyperlink performance, especially for terminals with a lot of content visible * gpui: Fall back to client-side decorations on Wayland if SSD not supported (zed-industries#39313) It is optional for Wayland servers to support server-side decorations. In particular, GNOME chooses to not implement SSD (https://gitlab.gnome.org/GNOME/mutter/-/issues/217). So, even if the application requests SSD, it must draw client-side decorations unless the application receives a response from the server confirming the request for SSD. Before, when the user requested SSD for Zed, but the Wayland server did not support it, there were no server-side decorations (window titlebar) drawn, but Zed did not draw the window minimize, maximize, and close buttons either. This fixes Zed so it always draws the window control buttons if the Wayland server does not support SSD. Before on GNOME Wayland with SSD requested: <img width="3840" height="2160" alt="image" src="https://github.com/user-attachments/assets/68a6d853-623d-401f-8e7f-21d4dea00543" /> After on GNOME Wayland with SSD requested: <img width="3840" height="2160" alt="image" src="https://github.com/user-attachments/assets/b258ae8b-fe0e-4ba2-a541-ef6f2c38f788" /> Release Notes: - Fixed window control buttons not showing in GNOME Wayland when SSD requested * Add setting for enabling server-side decorations (zed-industries#39250) Previously, this was controllable via the undocumented ZED_WINDOW_DECORATIONS environment variable (added in zed-industries#13866). Using an environment variable for this is inconvenient because it requires users to set that environment variable somehow before starting Zed, such as in the .desktop file or persistently in their shell. Controlling this via a Zed setting is more convenient. This does not modify the design of the titlebar in any way. It only moves the existing option from an environment variable to a Zed setting. Fixes zed-industries#14165 Client-side decorations (default): <img width="3840" height="2160" alt="image" src="https://github.com/user-attachments/assets/525feb92-2f60-47d3-b0ca-47c98770fa8c" /> Server-side decorations in KDE Plasma: <img width="3840" height="2160" alt="image" src="https://github.com/user-attachments/assets/7379c7c8-e5e3-47ba-a3ea-4191fec9434d" /> Release Notes: - Changed option for Wayland server-side decorations from an environment variable to settings.json field --------- Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com> * Retry sentry uploads (zed-industries#43267) We see internal server errors occasionally; and it's very annoying to have to re-run the entire step Release Notes: - N/A * git: Handle git pre-commit hooks separately (zed-industries#43285) We now run git pre-commit hooks before we commit. This ensures we don't run into timeout issues with askpass delegate and report invalid error to the user. Closes zed-industries#43157 Release Notes: - Fixed long running pre-commit hooks causing committing from Zed to fail. Co-authored-by: Cole Miller <cole@zed.dev> * Fix a bug where Anthropic completions would not work on nightly (zed-industries#43287) Follow up to: https://github.com/zed-industries/zed/pull/43185/files Release Notes: - N/A Co-authored-by: Michael <mbenfield@zed.dev> * askpass: Fix double command ampersand in powershell script (zed-industries#43289) Fixes zed-industries#42618 / zed-industries#43109 Release Notes: - N/A * Disable flaky `test_git_status_postprocessing` test (zed-industries#43293) Release Notes: - N/A * Fix wsl path parsing (zed-industries#43295) Closes zed-industries#40286 Release Notes: - N/A --------- Co-authored-by: John Tur <john-tur@outlook.com> * gpui: Fix documentation of window methods (zed-industries#43315) Closes zed-industries#43313 Release Notes: - N/A Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com> * Update JavaScript default language server (zed-industries#43316) As stated in [TypeScript Language Server documentation](https://zed.dev/docs/languages/typescript#language-servers), JavaScript uses `vtsls` as the default language server. Release Notes: - N/A * docs: Fix minor typo in docker.md (zed-industries#43334) Updated wording (added a missing word) for reporting issues in Dockerfile extension documentation. Closes #ISSUE N/A Release Notes: - N/A * ui: Remove `CheckboxWithLabel` and improve `Switch` and `Checkbox` (zed-industries#43343) This PR finally removes the `CheckboxWithLabel` component, which is not fully needed given the `Checkbox` can take a `label` method. Then, took advantage of the opportunity to add more methods with regards to label customization (position, size, and color) in both the `Checkbox` and `Switch` components. Release Notes: - N/A * debugger_ui: Improve some elements of the UI (zed-industries#43344) - In the launch tab of the new session mode, I've switched it to use the `InputField` component instead given that had all that we needed already. Allows for removing a good chunk of editor-related code - Also in the launch tab, added support for keyboard navigation between all of the elements there (dropdown, inputs, and switch component) - Added some simple an empty state treatment for the breakpoint column when there are none set https://github.com/user-attachments/assets/a441aa8a-360b-4e38-839f-786315a8a235 Release Notes: - debugger: Made the input elements within the launch tab in the new session modal keyboard navigable˙. * agent_ui: Display footer for model selector when in Zed agent (zed-industries#43294) This PR adds back the footer with the "Configure" button in the model selector but only when the seeing it from the Zed agent (or inline assistant/text threads). I had removed it a while back because seeing the "Configure" button, which takes you to the agent panel settings view, when clicking from an external agent didn't make much sense, given there's nothing model-wise you can configure from Zed (at least yet) for an external agent. This also makes the button in the footer a bit nicer by making it full screen and displaying a keybinding, so that you can easily do the whole "trigger model selector → go to settings view" all with the keyboard. <img width="400" height="870" alt="Screenshot 2025-11-21 at 10 38@2x" src="https://github.com/user-attachments/assets/c14f2acf-b793-4bc1-ac53-8a8a53b219e6" /> Release Notes: - N/A * Fix labels for GitHub issue templates (zed-industries#43348) Release Notes: - N/A * terminal_view: Reuse editor's blink manager (zed-industries#43351) Release Notes: - N/A *or* Added/Fixed/Improved ... * editor: Fix tab tooltips not showing file path for remote files (zed-industries#43359) Closes zed-industries#42344 Release Notes: - Fixed editor tab tooltips not showing file path for remote files Here's the before/after, tested both local and remote: https://github.com/user-attachments/assets/2768a0f8-e35b-4eff-aa95-d0decb51ec78 * Fix inline assist panic (zed-industries#43364) Fixes a panic that was introduced in zed-industries#42633. Repro steps: 1. Open the inline assistant and mention a file in the prompt 2. Run the inline assistant 3. Remove the mention and insert a different one 4. 💥 This would happen because the mention set still had a reference to the old editor, because we create a new one in `PromptEditor::unlink`. Also removes the unused `crates/agent_ui/src/context_picker/completion_provider.rs` file, which was not removed by mistake in the previous PR. Release Notes: - N/A * settings_ui: Don't show sh as default shell on windows (zed-industries#43276) Closes #ISSUE Release Notes: - Fixed an issue in the settings UI where changing the terminal shell would set the default shell to `sh` on Windows * Add mouse-based affordance to open a recent project in new window (zed-industries#43373) Closes zed-industries#31796 <img width="500" height="1034" alt="Screenshot 2025-11-23 at 7 39 2@2x" src="https://github.com/user-attachments/assets/bd516359-328f-44aa-9130-33f9567df805" /> Release Notes: - N/A * docs: Improve edit prediction page (zed-industries#43379) This PR improves the edit prediction page particularly by adding information about pricing and plans, which wasn't at all mentioned here before, _and_ by including a section with a keybinding example demonstrating how to always use just `tab` to always accept edit predictions. Release Notes: - N/A * agent_ui: Make thread markdown editable (zed-industries#43377) This PR makes the thread markdown editable. This refers to the "open thread as markdown" feature, where you previously could only read. One benefit of this move is that it makes a bit more obvious that you can `cmd-s` to save the markdown, allowing you to store the content of a given thread. You could already do this before, but due to it being editable now, you see the tab with a dirty indicator, which communicates that better. Release Notes: - agent: Made the thread markdown editable. * cli: Allow opening non-existent paths (zed-industries#43250) Changes are made to `parse_path_with_position`: we try to get the canonical, existing parts of a path, then append the non-existing parts. Closes zed-industries#4441 Release Notes: - Added the possibility to open a non-existing path using `zed` CLI ``` zed path/to/non/existing/file.txt ``` Co-authored-by: Syed Sadiq Ali <sadiqonemail@gmail.com> * miniprofiler_ui: Copy path to clipboard on click (zed-industries#43280) Release Notes: - N/A *or* Added/Fixed/Improved ... * Treat `.h++` files as C++ (zed-industries#42802) Release Notes: - `.h++` files are now treated as C++. * agent: Fix utf8 panic in outline (zed-industries#43141) Fixes ZED-3F3 Release Notes: - N/A *or* Added/Fixed/Improved ... * Add Windows path for extensions (zed-industries#42645) ### Description The `installing-extensions.md` guide was missing the directory path for the Windows platform. It currently only lists the paths for macOS and Linux. This PR adds the correct path for Windows users (`%LOCALAPPDATA%\zed\extensions`). Release Notes: - N/A --------- Co-authored-by: Kirill Bulatov <mail4score@gmail.com> * Fix gutter hover breakpoint not updating when switching the tabs (zed-industries#43163) Closes zed-industries#42073 fixes hover breakpoint not disappearing from a tab when tabs are switched https://github.com/user-attachments/assets/43096d2a-cc5b-46c4-b903-5bc8c33305c5 Release Notes: - N/A --------- Co-authored-by: Finn Evers <finn.evers@outlook.de> * docs: Document `git_hosting_providers` for self-hosted Git instances (zed-industries#43278) Closes zed-industries#38433 Document how to register self-hosted GitHub/GitLab/Bitbucket instances via git_hosting_providers setting so permalinks and issue links resolve. Release Notes: - Added documentation on how to register self-hosted GitHub/GitLab/Bitbucket instances via the `git_hosting_providers` setting. This ensures permalinks and issue links can be resolved for these instances. * fix errors * add missing field * update script --------- Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com> Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com> Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com> Co-authored-by: Andrew Farkas <6060305+HactarCE@users.noreply.github.com> Co-authored-by: Cole Miller <cole@zed.dev> Co-authored-by: jtaub <65861679+jtaub@users.noreply.github.com> Co-authored-by: Lukas Wirth <lukas@zed.dev> Co-authored-by: Kunall Banerjee <14703164+yeskunall@users.noreply.github.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com> Co-authored-by: Agus Zubiaga <agus@zed.dev> Co-authored-by: Luke Naylor <luke@grahamnaylor.net> Co-authored-by: Ben Kunkle <ben@zed.dev> Co-authored-by: Bennet Bo Fenner <bennet@zed.dev> Co-authored-by: Danilo Leal <daniloleal09@gmail.com> Co-authored-by: Joseph T. Lyons <JosephTLyons@gmail.com> Co-authored-by: Dave Waggoner <waggoner.dave@gmail.com> Co-authored-by: Be <be.0@gmx.com> Co-authored-by: Jakub Konka <kubkon@jakubkonka.com> Co-authored-by: Mikayla Maki <mikayla@zed.dev> Co-authored-by: Michael <mbenfield@zed.dev> Co-authored-by: Julia Ryan <juliaryan3.14@gmail.com> Co-authored-by: John Tur <john-tur@outlook.com> Co-authored-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com> Co-authored-by: Liffindra Angga Zaaldian <3760093+findrakecil@users.noreply.github.com> Co-authored-by: warrenjokinen <110791849+warrenjokinen@users.noreply.github.com> Co-authored-by: Mayank Verma <errmayank@gmail.com> Co-authored-by: Ulysse Buonomo <buonomo.ulysse@gmail.com> Co-authored-by: Syed Sadiq Ali <sadiqonemail@gmail.com> Co-authored-by: Benjamin Jurk <106487517+bnjmnjrk@users.noreply.github.com> Co-authored-by: mg <108034506+mg0x7BE@users.noreply.github.com> Co-authored-by: Kirill Bulatov <mail4score@gmail.com> Co-authored-by: shaik-zeeshan <145040231+shaik-zeeshan@users.noreply.github.com> Co-authored-by: Finn Evers <finn.evers@outlook.de> Co-authored-by: Oscar Villavicencio <odvcencio@users.noreply.github.com> Co-authored-by: wzulfikar <>
dvdsk
pushed a commit
that referenced
this pull request
Nov 25, 2025
Closes #42344 Release Notes: - Fixed editor tab tooltips not showing file path for remote files Here's the before/after, tested both local and remote: https://github.com/user-attachments/assets/2768a0f8-e35b-4eff-aa95-d0decb51ec78
11happy
pushed a commit
to 11happy/zed
that referenced
this pull request
Dec 1, 2025
…industries#43359) Closes zed-industries#42344 Release Notes: - Fixed editor tab tooltips not showing file path for remote files Here's the before/after, tested both local and remote: https://github.com/user-attachments/assets/2768a0f8-e35b-4eff-aa95-d0decb51ec78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42344
Release Notes:
Here's the before/after, tested both local and remote:
screen-recording-remote-file-path.mov