Avoid dependencies build errors on Windows #7827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
kazatsuyu
commented
Feb 15, 2024
Cargo.toml
Outdated
| @@ -257,16 +257,16 @@ tree-sitter-ocaml = { git = "https://github.com/tree-sitter/tree-sitter-ocaml", | |||
| tree-sitter-php = "0.21.1" | |||
| tree-sitter-prisma-io = { git = "https://github.com/victorhqc/tree-sitter-prisma" } | |||
| tree-sitter-proto = { git = "https://github.com/rewinfrey/tree-sitter-proto", rev = "36d54f288aee112f13a67b550ad32634d0c2cb52" } | |||
| tree-sitter-purescript = { git = "https://github.com/ivanmoreau/tree-sitter-purescript", rev = "a37140f0c7034977b90faa73c94fcb8a5e45ed08" } | |||
| tree-sitter-purescript = { git = "https://github.com/kazatsuyu/tree-sitter-purescript", rev = "e21296ba922de592bd49365f6ada4deef6bbe9a5" } | |||
There was a problem hiding this comment.
I would not like to maintain this repository for the long term. However, tree-sitter will move to extensions, so if it is ok to keep this repository for the short term, I will remove the draft mark.
Since this repository is a fork of a fork of a fork, we should be able to use one of the upstreams in the future.
There was a problem hiding this comment.
Since tree-sitter-purescript is already ignored on linux, I decided to remove it as a dependency once rather than blocking work for it.
kazatsuyu
commented
Feb 15, 2024
| @@ -38,6 +38,9 @@ smol.workspace = true | |||
| theme.workspace = true | |||
| util.workspace = true | |||
|
|
|||
| [target.'cfg(windows)'.dependencies] | |||
| async-std = { version = "1.12.0", features = ["unstable"] } | |||
There was a problem hiding this comment.
async-tar lacks this feature
kazatsuyu
force-pushed
the
windows-avoid-dependency-build-error
branch
from
1b0c289 to
90f3101
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a compilation of fixes for errors that appeared in dependent crates in Windows.
Release Notes: