Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences page — form: label/input for/id relation missing #1003

Open
luce-carevic opened this issue Aug 29, 2023 · 0 comments
Open

Preferences page — form: label/input for/id relation missing #1003

luce-carevic opened this issue Aug 29, 2023 · 0 comments
Labels
accessibility Accessibility issue

Comments

@luce-carevic
Copy link

There is no for/id relation between some label and input.

Screenshort of the preferences form

Example:

<label for="theme">Theme</label> 
<select name="theme">[…]</select>

Should be :

<label for="theme">Theme</label> 
<select name="theme" id="theme">[…]</select>

Similar issue

In the link replacements section.

Screenshot — code of the link replacements section

Should be :

  • <input name="replaceTwitter" id="replaceTwitter" type="text" placeholder="Nitter hostname" value="" autofocus="">
  • <input name="replaceYouTube" id="replaceYouTube" type="text" placeholder="Piped hostname" value="" autofocus="">
  • <input name="replaceReddit" id="replaceReddit" type="text" placeholder="Teddit hostname" value="" autofocus="">

Even though associating labels implicitly can be OK, explicit labels are better supported by assistive technology. Consider adding a for/id liaison between label and input.

See:

@luce-carevic luce-carevic changed the title Preferences page — form: label/input for/id relation missing Preferences page — form: label/input for/id relation missing #a11y Aug 29, 2023
@luce-carevic luce-carevic changed the title Preferences page — form: label/input for/id relation missing #a11y Preferences page — form: label/input for/id relation missing Aug 29, 2023
@zedeus zedeus added the accessibility Accessibility issue label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Accessibility issue
Projects
None yet
Development

No branches or pull requests

2 participants