Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some accessibility issues #1005

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hannaeko
Copy link

Hello, I am trying to address some of the accessibility issues raised in #998, #1001, #1002 and #1003.

Changes:

  • replace div by main for .container element
  • change about page title to be "About | nitter.net"
  • add role, label and title for liberapay icon / link
  • use explicit label to link label to input (this also changed the way checkbox are styled, from a span directly following the checkbox to styling the checkbox directly)
  • use separate fieldsets to group inputs in preference form

Cheers,
Gaël

@untitaker
Copy link

this patch is now deployed on nitter.woodland.cafe -- lighthouse a11y score seems to marginally improve on tweets, so I consider that a win

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants