-
-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Recommendations #444
base: master
Are you sure you want to change the base?
Conversation
de32dbd
to
f9cb0a1
Compare
f9c3c5f
to
3dee341
Compare
41ba7b8
to
3a279e2
Compare
3a279e2
to
d95311b
Compare
@@ -449,6 +449,10 @@ proc parseTimeline*(js: JsonNode; after=""): Timeline = | |||
elif "cursor-bottom" in entry: | |||
result.bottom = e.getCursor | |||
|
|||
proc parseRecommnedations*(js: JsonNode): Recommendations = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo
ok. I will make it a preference.
I'd like to fetch all and then random show user 3 of them. It is just because I hate that when i click show more in twitter page, they ask me to login :-( it will take some days to finish these all. |
Picking 3 by random could work, but I wonder if they rank/sort the list somehow, which would result in worse recommendations of course. Do you know? Looking at some API responses and manually assessing how relevant the results are for a few examples should be enough to get a feel for how they do it. |
Due to a semi-emergency caused by Twitter I had to make a lot of changes, especially in |
UI looks like:
Desktop
Mobile:
1.toggle off
2.toggle on
TODO:Should we limit numbers of recommendations in twitter api. or limit numbers in display (random pick) or just display them all?