Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build zbchaos docker image #192

Merged
merged 7 commits into from
Oct 14, 2022
Merged

Build zbchaos docker image #192

merged 7 commits into from
Oct 14, 2022

Conversation

lenaschoenburg
Copy link
Contributor

@lenaschoenburg lenaschoenburg commented Oct 12, 2022

Depends on #191

Builds a docker image gcr.io/zeebe-io/zbchaos that runs zbchaos (with the worker command by default).

@lenaschoenburg lenaschoenburg force-pushed the os-zbchaos-docker-image branch 3 times, most recently from 259f4ec to 30f4857 Compare October 12, 2022 12:09
Copy link
Member

@ChrisKujawa ChrisKujawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mega 🚀

COPY --link go.mod go.sum .
RUN go mod download

COPY --link cmd/ ./cmd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL: --link creates a symlink? Wasnt aware of this feature 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly but it allows to copy files independently from previous layers: https://docs.docker.com/engine/reference/builder/#copy---link

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok this is not what I expected but OK :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I feel like a lot of the more recent docker features are really subtle and not easy to understand 😬

@ChrisKujawa ChrisKujawa merged commit 5b8e0b5 into main Oct 14, 2022
@ChrisKujawa ChrisKujawa deleted the os-zbchaos-docker-image branch October 14, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants