-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new integration tests #267
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9beb999
test: add test for run command
ChrisKujawa 9c8880c
test: new chaos worker test
ChrisKujawa abef514
test: add first testcontainer integration test
ChrisKujawa adf80e1
style: rm empty line
ChrisKujawa c31eed1
test: add new experiment definition
ChrisKujawa 1128dd3
refactor: add more verbose logging for the workers
ChrisKujawa 27e03ac
refactor: extract worker opening
ChrisKujawa bdc8dae
test: new integration test
ChrisKujawa 7153c37
style: add license
ChrisKujawa 8601d0a
fix: use correct fmt
ChrisKujawa 7572a74
test: remove duplicate test
ChrisKujawa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| // Copyright 2022 Camunda Services GmbH | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package cmd | ||
|
|
||
| import ( | ||
| "context" | ||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| "io" | ||
| "os" | ||
| "testing" | ||
| ) | ||
|
|
||
| func SetStdOut(out *os.File) { | ||
| os.Stdout = out | ||
| } | ||
|
|
||
| func Test_ShouldRunCommand(t *testing.T) { | ||
| // given | ||
| rescueStdout := os.Stdout | ||
| defer SetStdOut(rescueStdout) | ||
| r, w, err := os.Pipe() | ||
| require.NoError(t, err) | ||
| SetStdOut(w) | ||
| args := []string{"version"} | ||
|
|
||
| // when | ||
| err = runZbChaosCommand(args, context.TODO()) | ||
|
|
||
| // then | ||
| w.Close() | ||
| require.NoError(t, err) | ||
| out, err := io.ReadAll(r) | ||
| outStr := string(out) | ||
| assert.Contains(t, outStr, "Running command with args: [version] ") | ||
| assert.Contains(t, outStr, "zbchaos development (commit: HEAD)") | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙃 I think this test is not adding much value.
runZbChaosCommanddoesn't do much other than just delegating to the cobra command.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to keep it. With this unit test failing, I can faster pin-point where an issue is, instead of having only a failed integration test.