Do not fail retry of scale up operation #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add it as a separate step, because this can take longer than the default 5 minutes. When the whole operation is retried scale up request fails because there is an ongoing change. By splitting up into two steps, only query has to be retried.
lenaschoenburg
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scale up operation can some times take longer depending on the size of data in each partition. By default the job is locked for 5 minutes and retried after. If the scale up operation do not complete with in this 5 minutes, the retry failed because there is already an operation in progress. This results in an incident after 3 retries. Manual retry to resolve incident also failed because the command fails when the clusterSize is already the requested one.
This PR fixes this by:
waithas to be retried. Since it is a query, it can be safely retried.waitin chaos experiments and e2e tests, allow it to run without specifiying a changeId. When no changeId is specified, it reads the changeId from thependingChangeorlastChange.