Use proper Python package for tree-sitter-zeek #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbannier
commented
May 16, 2024
bbannier
force-pushed
the
topic/bbannier/tree-sitter-zeek-package
branch
2 times, most recently
from
8c9c78e
to
3c76b51
Compare
bbannier
commented
May 16, 2024
bbannier
force-pushed
the
topic/bbannier/tree-sitter-zeek-package
branch
2 times, most recently
from
2949791
to
2d6a200
Compare
bbannier
force-pushed
the
topic/bbannier/tree-sitter-zeek-package
branch
from
2d6a200
to
151dab5
Compare
bbannier
added a commit
to zeek/tree-sitter-zeek
that referenced
this pull request
Jun 19, 2024
Since 1c279c4 this package contains everything needed for it to be used on its own, e.g., downstream consumers like https://github.com/zeek/zeekscript/ can directly depend on this package and would not need to perform manual building of the parser anymore, see zeek/zeekscript#72. The only missing piece, at least in the Python ecosystem, was that before zeek/zeekscript#72 that package would publish wheels so users could install the tool without needing e.g., a C compiler. With parser compilation moved from zeek/zeekscript into tree-sitter-zeek zeekscript does not need to build any wheels anymore (it is a source-only package); instead we should provide wheels for tree-sitter-zeek which this patch implements. Note: The action I used here can also publish packages for NPM and Rust crates. These ecosystems are much more comfortable with requiring a compiler, so I deliberately did not set this up.
bbannier
force-pushed
the
topic/bbannier/tree-sitter-zeek-package
branch
from
254b62a
to
2c244f5
Compare
bbannier
force-pushed
the
topic/bbannier/tree-sitter-zeek-package
branch
from
c798197
to
72a49af
Compare
This patch largely empties out `setup.py` and instead uses keys corresponding keys `pyproject.toml`. The only remaining use we have for `setup.py` is to build Python bindings for tree-sitter-zeek and to compute a dynamic version from the `VERSION` file tracked in the repo.
tree-sitter-zeek now provides a Python package we can directly depend on. With this we can avoid building and shipping the generated tree-sitter bindings. By using the "official upstream API" we can also simplify the way we parse input.
With tree-sitter-zeek providing a proper Python package this project is script-only.
bbannier
force-pushed
the
topic/bbannier/tree-sitter-zeek-package
branch
from
72a49af
to
8a6f557
Compare
ckreibich
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.