Expose Serializer and Deserializer directly
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twey
force-pushed
the
expose-serde-zefchain
branch
from
45c7a6b
to
dd47878
Compare
Allows external projects to plug BCS into libraries that expect a `serde` `Serializer` or `Deserializer` implementation.
Twey
force-pushed
the
expose-serde-zefchain
branch
from
dd47878
to
2009023
Compare
ma2bd
approved these changes
Nov 22, 2023
| @@ -479,8 +479,7 @@ where | |||
| } | |||
| } | |||
|
|
|||
| #[doc(hidden)] | |||
There was a problem hiding this comment.
It was previously redundant, but you're right, it's now relevant. I was fooled by this regression in rustc — but I see that as the older rustc in CI finds, this is indeed incorrect since we're accidentally exposing the internal BcsDeserializer trait.
I'm a bit loath to expose BcsDeserializer, though, which looks to be quite internal, so I'll look at refactoring it when I get a moment. I have a suspicion it can be broken down into Read/BufRead + serde::Deserializer — or even if it can't completely we can expose those more standard bounds instead of the internal BcsDeserializer.
|
I'm going to close this because the change didn't get support from everyone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows external projects to plug BCS into libraries that expect a
serdeSerializerorDeserializerimplementation.