Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openshift objects validation #142

Open
andywow opened this issue Jun 20, 2019 · 4 comments
Open

Openshift objects validation #142

andywow opened this issue Jun 20, 2019 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@andywow
Copy link

andywow commented Jun 20, 2019

Hello, it will be nice, if kube-score will validate openshift objects: Route (Ingress analog) and DeploymentConfig (Deployment analog)

@zegl
Copy link
Owner

zegl commented Jun 21, 2019

Hey, I’m not very familiar with OpenShift, but I don’t see any reason for why this project should not support it. Pull Requests are welcome.

@zegl zegl added the help wanted Extra attention is needed label Jun 21, 2019
@030
Copy link

030 commented Feb 25, 2021

@andywow Could you indicate what Kind of OpenShift objects should be validated, e.g. BuildConfigs, DeploymentConfigs, ImageStreams, Routes. I think that we should to validate one.

@030
Copy link

030 commented Feb 25, 2021

@zegl could you give me some pointers? For example, an OpenShift DeploymentConfig is the equivalent of a Deployment in k8s. Should I create a new file? What is the best way to start in this project?

apiVersion: v1
kind: DeploymentConfig
metadata:
  name: frontend
spec:
  replicas: 5
  selector:
    name: frontend
  template: { ... }
  triggers:
  - type: ConfigChange 
  - imageChangeParams:
      automatic: true
      containerNames:
      - helloworld
      from:
        kind: ImageStreamTag
        name: hello-openshift:latest
    type: ImageChange  
  strategy:
    type: Rolling      

Source: https://docs.openshift.com/container-platform/4.1/applications/deployments/what-deployments-are.html

@neilchaudhuri
Copy link

Curious if anyone has figured out a way to do this as an extension of the current library or if it will take a PR to make it happen

BigGold1310 added a commit to BigGold1310/kube-score that referenced this issue Jan 5, 2024
Updates zegl#142

Signed-off-by: Cyrill N. <cyrill.naef@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants