Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render/junit: add new output #603

Merged
merged 3 commits into from
Jul 12, 2024
Merged

render/junit: add new output #603

merged 3 commits into from
Jul 12, 2024

Conversation

sebhoss
Copy link
Contributor

@sebhoss sebhoss commented Jun 11, 2024

This produces JUnit XML compatible output when the 'junit' output format is specified.

Fixes #459

RELNOTE: Add JUnit output format option

This produces JUnit XML compatible output when the 'junit' output format is specified.

Fixes zegl#459

Signed-off-by: Sebastian Hoß <seb@xn--ho-hia.de>
@zegl
Copy link
Owner

zegl commented Jun 14, 2024

Thanks for the PR! I'll take a look at it over the weekend.

@sebhoss
Copy link
Contributor Author

sebhoss commented Jun 14, 2024

thanks a lot! I wasn't really sure about the data structures used by kube-scoren, so I'm happy to change all code in this PR to whatever works best for you 👍

@gruzchik
Copy link
Contributor

gruzchik commented Jul 7, 2024

Hey guys! @zegl , @sebhoss could you please let us know when you merge and update this feature. We are using Gitlab and I have proposed to use kube-score for validation, it would be nice to be able to use JUnit to implement kube-score

@zegl
Copy link
Owner

zegl commented Jul 12, 2024

I found that the output format was not added to main.go (and was not considered a valid option), other than that, looks good!

@zegl zegl merged commit 536c54b into zegl:master Jul 12, 2024
@sebhoss
Copy link
Contributor Author

sebhoss commented Jul 12, 2024

This is really cool - thanks a lot @zegl!

@gruzchik
Copy link
Contributor

@sebhoss , @zegl very appreciated for your work! I'm looking forward to adding this update to the release, it would be nice to have opportunity to use this as an official stable version

@sebhoss sebhoss deleted the junit-output branch July 21, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Support JUnit XML output format
3 participants