Updated to use Nan and multiple versions of Node.js up to 5 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and hopefully onwards). Tested on 5.4.1
|
Hello, |
|
My pleasure, hope it helps! I had a bit of spare time (and a spare Raspberry Pi!) so I tried installing the module on node 0.10.29 and I'm getting the error in Nan that is outlined here : nodejs/nan#414 Which is annoying. It seems like there's something wrong with the version of gyp-node that comes with npm 1.4.21. I'm trying to see if I can upgrade gyp-node now... I'll let you know how I get along. Seb |
|
Found a slight problem with it, I think I've fixed it, will make a new PR when I'm sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewritten in the style recommended in https://github.com/nodejs/node-addon-examples for Nan (https://github.com/nodejs/nan) so should be good for versions 0.8, 0.10, 0.12, 4 and 5.
Tested on 5.4.1, needs testing on other versions.