-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Kanji + some adjacent docs #1536
Conversation
|
Yeah. By doc'd I mean named the file, function, and data. Don't think I can do anything else without commiting the assembly. |
I guess we could have a header and comments explaining what does the function do, what takes as arguments and whats the return value. But it is fine as it currently is |
Ah I really like that idea. Let me do that real quick. |
Kanji textures are now documented. Thank you Emily :) . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really have a way to verify if every Japanese character is correct, but I trust you two for getting them right
zeldaret/mm#1536 Co-authored-by: Derek Hensley <hensley.derek58@gmail.com> Co-authored-by: emilybrooks <emilybrooksemilybrooks@gmail.com>
zeldaret/mm#1536 Co-authored-by: Derek Hensley <hensley.derek58@gmail.com> Co-authored-by: emilybrooks <emilybrooksemilybrooks@gmail.com>
zeldaret/mm#1536 Co-authored-by: Derek Hensley <hensley.derek58@gmail.com> Co-authored-by: emilybrooks <emilybrooksemilybrooks@gmail.com>
* Extract NTSC assets for gc-us * Extract kanji zeldaret/mm#1536 Co-authored-by: Derek Hensley <hensley.derek58@gmail.com> Co-authored-by: emilybrooks <emilybrooksemilybrooks@gmail.com> --------- Co-authored-by: Derek Hensley <hensley.derek58@gmail.com> Co-authored-by: emilybrooks <emilybrooksemilybrooks@gmail.com>
Extracts everything from the kanji file. I added the codepoint index similar to nes font,
though did not actually fully name the textures just used their offset (would prefer someone who actually knows the japanese characters to do it). Textures are named thanks to Emily.Also doc'd as much as possible code_80185F90.text.s (kanread.s) which is related.