Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Kanji + some adjacent docs #1536

Merged
merged 8 commits into from
Jan 21, 2024
Merged

Extract Kanji + some adjacent docs #1536

merged 8 commits into from
Jan 21, 2024

Conversation

hensldm
Copy link
Collaborator

@hensldm hensldm commented Jan 14, 2024

Extracts everything from the kanji file. I added the codepoint index similar to nes font, though did not actually fully name the textures just used their offset (would prefer someone who actually knows the japanese characters to do it). Textures are named thanks to Emily.
Also doc'd as much as possible code_80185F90.text.s (kanread.s) which is related.

@AngheloAlf
Copy link
Collaborator

Also doc'd as much as possible code_80185F90.text.s (kanread.s) which is related.
I don't see the docs anywhere. In case you documented the actual assembly file remember that we don't commit the assembly files

@hensldm
Copy link
Collaborator Author

hensldm commented Jan 14, 2024

Also doc'd as much as possible code_80185F90.text.s (kanread.s) which is related.

I don't see the docs anywhere. In case you documented the actual assembly file remember that we don't commit the assembly files

Yeah. By doc'd I mean named the file, function, and data. Don't think I can do anything else without commiting the assembly.

@AngheloAlf
Copy link
Collaborator

I don't see the docs anywhere. In case you documented the actual assembly file remember that we don't commit the assembly files

Yeah. By doc'd I mean named the file, function, and data. Don't think I can do anything else without commiting the assembly.

I guess we could have a header and comments explaining what does the function do, what takes as arguments and whats the return value. But it is fine as it currently is

@hensldm
Copy link
Collaborator Author

hensldm commented Jan 14, 2024

I don't see the docs anywhere. In case you documented the actual assembly file remember that we don't commit the assembly files

Yeah. By doc'd I mean named the file, function, and data. Don't think I can do anything else without commiting the assembly.

I guess we could have a header and comments explaining what does the function do, what takes as arguments and whats the return value. But it is fine as it currently is

Ah I really like that idea. Let me do that real quick.

@hensldm
Copy link
Collaborator Author

hensldm commented Jan 18, 2024

Kanji textures are now documented. Thank you Emily :) .

@tom-overton tom-overton removed the Needs-first-approval First approval label Jan 18, 2024
Copy link
Collaborator

@AngheloAlf AngheloAlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really have a way to verify if every Japanese character is correct, but I trust you two for getting them right

@engineer124 engineer124 added Merge-ready All reviewers satisfied, just waiting for CI and removed Needs-second-approval Second approval labels Jan 21, 2024
@engineer124 engineer124 merged commit 6a15ce9 into zeldaret:main Jan 21, 2024
@hensldm hensldm deleted the kanji branch January 21, 2024 03:38
cadmic added a commit to cadmic/oot that referenced this pull request Jun 22, 2024
zeldaret/mm#1536

Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
Co-authored-by: emilybrooks <emilybrooksemilybrooks@gmail.com>
cadmic added a commit to cadmic/oot that referenced this pull request Jun 24, 2024
zeldaret/mm#1536

Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
Co-authored-by: emilybrooks <emilybrooksemilybrooks@gmail.com>
cadmic added a commit to cadmic/oot that referenced this pull request Jun 25, 2024
zeldaret/mm#1536

Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
Co-authored-by: emilybrooks <emilybrooksemilybrooks@gmail.com>
fig02 pushed a commit to zeldaret/oot that referenced this pull request Jun 26, 2024
* Extract NTSC assets for gc-us

* Extract kanji

zeldaret/mm#1536

Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
Co-authored-by: emilybrooks <emilybrooksemilybrooks@gmail.com>

---------

Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
Co-authored-by: emilybrooks <emilybrooksemilybrooks@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Asset Merge-ready All reviewers satisfied, just waiting for CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants