Document Arrow Related Actor Flags #1737
Open
+48
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engineer124
added
documentation
isghj5
approved these changes
Nov 6, 2024
hensldm
approved these changes
Nov 7, 2024
| @@ -369,7 +369,7 @@ void EnFg_Update(Actor* thisx, PlayState* play) { | |||
| flagSet = CHECK_FLAG_ALL(flag, ACTOR_FLAG_2000); | |||
| if (1) {} | |||
| if (!flagSet) { | |||
| flagSet = CHECK_FLAG_ALL(flag, ACTOR_FLAG_8000); | |||
| flagSet = CHECK_FLAG_ALL(flag, ACTOR_FLAG_ATTACHED_TO_ARROW); | |||
There was a problem hiding this comment.
Not sure if better/should be done in this PR, but you can remove the temps and if (1)s by doing
if ((CHECK_FLAG_ALL(this->actor.flags, ACTOR_FLAG_2000) == 0) &&
(CHECK_FLAG_ALL(this->actor.flags, ACTOR_FLAG_8000) == 0)) {
this->actionFunc(this, play);
Actor_UpdateBgCheckInfo(play, &this->actor, sREG(0), sREG(1), 0.0f,
UPDBGCHECKINFO_FLAG_1 | UPDBGCHECKINFO_FLAG_4);
}
hensldm
added
Merge-ready
engineer124
removed
the
Waiting-for-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See zeldaret/oot#2284