Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some progress on frame.c #56

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Some progress on frame.c #56

merged 2 commits into from
Sep 25, 2024

Conversation

Yanis002
Copy link
Collaborator

  • matched frameResetCache, frameDrawSyncCallback, fn_8004BF58 and frameLoadTexturePack
  • fixed the function order (from frameConvertYUVtoRGB to frameLoadTile it's frame.c, then after that _frameRVL.c was #included, and from frameDrawReset it's frame.c again
  • removed unused functions (though I suspect some of them might be used but I couldn't figure out that part so that's why there's still unnamed functions)
  • improved a little/match some sections

I don't have a lot of motivation of continuing working on this file since it's a tough one but I'm glad I could improve it a bit, also I realised way too late I should've done separate commits for this sorry

cadmic
cadmic approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@cadmic cadmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low effort review, sorry

include/revolution/os/OSFastCast.h Outdated Show resolved Hide resolved
@Yanis002 Yanis002 merged commit b6a2700 into zeldaret:main Sep 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cadmic cadmic cadmic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yanis002 @cadmic