Document fog functions Gfx_SetFog(2) and Play_SetFog #1922

Thar0 · 2024-03-08T03:22:20Z

Finally an explanation for the weird SPFogFactor values.

Thanks Wiseguy for pointing out the overflow issue when near and far are close

Dragorn421 · 2024-03-08T04:24:49Z

src/code/z_rcp.c

+        // Calculating the fog multiplier when far = 1000 and near >= 997 using `128000 / (far - near)` as in
+        // SPFogPosition would result in an overflow since 128000 / (1000 - 997) > 32767. Avoid this overflow by
+        // effectively clamping near to ~996. This is almost SPFogPosition(996.0937f, 1000)
+        gSPFogFactor(gfx++, 0x7FFF, -0x7F00); // Fixed point: 0x7FFF = 1.0, -0x7F00 = -0.992


fm and fo are s0.15 ? Where is this from
Seems inconsistent with the formula
fogAlpha=fm*z+fo z in [-1;1] fogAlpha in [0;255]
(cf gbi.h)

f(z) = clamp(32767 * z - 32512, 0, 255) for z in [-1,1] produces the curve (only the interesting part shown)

32512 is chosen so that f(z)=255 at z=1

There's some weirdness in how the microcode actually computes this since z itself isn't really in the interval [-1,1], it's in s15.16 format. The calculation is something like

vmudh $v__, fo, [1,1,1,1,1,1,1,1] // ACC = (fo * [1,1,1,1,1,1,1,1]) << 16 vmadh $v__, [0, 0, 0, 1, 0, 0, 0, 1], v31_0x7F00 // ACC += ([0,0,0,1,0,0,0,1] * 0x7F00) << 16 vmadn $v26, pos, fm // frac. part, $v26 = low16(ACC += pos * fm) vmadh $v25, pos, fm // int. part, $v25 = mid16(ACC += (pos * fm) << 16)

https://github.com/Mr-Wiseguy/f3dex2/blob/master/f3dex2.s#L1432
I have yet to take the time to carefully check the units involved here

then if to interpret 0x7FFF and the other as s0.15 you rely on interpreting z as s15.16 that should be written somewhere too, otherwise it's kinda arbitrary/useless to use any unit

cadmic · 2024-03-09T02:57:50Z

src/code/z_rcp.c

 Gfx* Gfx_SetFog(Gfx* gfx, s32 r, s32 g, s32 b, s32 a, s32 near, s32 far) {
+    // Ensure fog far is greater than near


this only ensures that near != far, right?

it ensures that far is greater than near only in the case where they are initially the same. like, the important bit that tharo is stressing here is that far gets incremented by 1 to be bigger.
but its prob good to clarify that in the wording

Suggested change

// Ensure fog far is greater than near

// Avoid 0 divisor in gSPFogPosition below

Dragorn421 · 2024-03-10T22:49:27Z

src/code/z_play.c

+ * Set the default fog state controlled by the environment system.
+ * If a custom fog state is used in rendering it is expected that it be reset back to this default state.


forgive me but I find this comment somewhat clunky, I tried to rewrite it more to my liking

* Set the environment fog, from parameters controlled by the environment system. * If a custom fog state is momentarily used in drawing, the environment fog is expected to be restored afterwards.

Dragorn421 · 2024-03-10T22:54:35Z

src/code/z_rcp.c

+ * Set fog color and range.
+ *
+ * At or prior to fog near, geometry is unaffected by fog. At or beyond fog far, geometry is fully fogged.
+ * Between near and far pixels will be linearly interpolated between the unfogged color and the supplied fog color.


Suggested change

* Between near and far pixels will be linearly interpolated between the unfogged color and the supplied fog color.

* Between near and far the geometry color will be interpolated between the unfogged color and the supplied fog color.

it is "some z"-linear but not view space z linear when using perspective projection (I forgot the details (if I ever grasped them)), anyway so I don't think specifying linear is all that useful

Dragorn421 · 2024-03-10T22:56:51Z

src/code/z_rcp.c

 Gfx* Gfx_SetFog(Gfx* gfx, s32 r, s32 g, s32 b, s32 a, s32 near, s32 far) {
+    // Ensure fog far is greater than near


Suggested change

// Ensure fog far is greater than near

// Avoid 0 divisor in gSPFogPosition below

Dragorn421 · 2024-03-10T23:02:42Z

src/code/z_rcp.c

    gDPSetFogColor(gfx++, r, g, b, a);

    if (near >= 1000) {
+        // Fog far is expected to be at most 1000 so near >= far. Set a constant shade alpha of 0 for no fog


Suggested change

// Fog far is expected to be at most 1000 so near >= far. Set a constant shade alpha of 0 for no fog

// Set a constant shade alpha of 0 for no fog

I wouldn't write anything on why, this whole function is sloppy without good "why"s anyway

Dragorn421 · 2024-03-10T23:05:16Z

src/code/z_rcp.c

    } else if (near < 0) {
+        // Fog near is out of range. Set a constant shade alpha of 255 for fully fogged


Suggested change

// Fog near is out of range. Set a constant shade alpha of 255 for fully fogged

// Set a constant shade alpha of 255 for fully fogged

Dragorn421 · 2024-03-10T23:12:41Z

src/code/z_rcp.c

+        //! @bug If the difference between near and far is not at least 4, the fog multiplier will overflow. This is
+        //! handled above when fog far is 1000 but for closer fog far it is not accounted for.


Suggested change

//! @bug If the difference between near and far is not at least 4, the fog multiplier will overflow. This is

//! handled above when fog far is 1000 but for closer fog far it is not accounted for.

//! @bug If far - near < 4, the computed `fm` fog factor coefficient will overflow.

//! For example: 128000 / (983 - 980) > 32767

//! This is handled above in the case of near > 996, but the general case is not accounted for.

Dragorn421 · 2024-03-10T23:13:12Z

src/code/z_rcp.c

+        // Calculating the fog multiplier when far = 1000 and near >= 997 using `128000 / (far - near)` as in
+        // SPFogPosition would result in an overflow since 128000 / (1000 - 997) > 32767. Avoid this overflow by
+        // effectively clamping near to ~996. This is almost SPFogPosition(996.0937f, 1000)


I suggest moving details to the general case else { below and making this part lighter

Suggested change

// Calculating the fog multiplier when far = 1000 and near >= 997 using `128000 / (far - near)` as in

// SPFogPosition would result in an overflow since 128000 / (1000 - 997) > 32767. Avoid this overflow by

// effectively clamping near to ~996. This is almost SPFogPosition(996.0937f, 1000)

// Avoid an overflow when near and far are close (see bug below), by effectively clamping near to ~996.

// This is almost SPFogPosition(996.0937f, 1000)

Document fog functions Gfx_SetFog(2) and Play_SetFog

df59993

Dragorn421 reviewed Mar 8, 2024

View reviewed changes

cadmic approved these changes Mar 9, 2024

View reviewed changes

Dragorn421 added the Needs second approval label Mar 10, 2024

Dragorn421 reviewed Mar 10, 2024

View reviewed changes

fig02 added the Waiting for author There are requested changes that have not been addressed label Mar 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Document fog functions Gfx_SetFog(2) and Play_SetFog #1922

Document fog functions Gfx_SetFog(2) and Play_SetFog #1922

Thar0 commented Mar 8, 2024

Dragorn421 Mar 8, 2024

Thar0 Mar 8, 2024

Dragorn421 Mar 10, 2024

cadmic Mar 9, 2024

fig02 Mar 10, 2024

Dragorn421 Mar 10, 2024

Dragorn421 Mar 10, 2024 •

edited

Loading

Dragorn421 Mar 10, 2024

Dragorn421 Mar 10, 2024

Dragorn421 Mar 10, 2024

Dragorn421 Mar 10, 2024

Dragorn421 Mar 10, 2024

Dragorn421 Mar 10, 2024

		Gfx* Gfx_SetFog(Gfx* gfx, s32 r, s32 g, s32 b, s32 a, s32 near, s32 far) {
		// Ensure fog far is greater than near

	// Ensure fog far is greater than near
	// Avoid 0 divisor in gSPFogPosition below

		* Set the default fog state controlled by the environment system.
		* If a custom fog state is used in rendering it is expected that it be reset back to this default state.

	* Between near and far pixels will be linearly interpolated between the unfogged color and the supplied fog color.
	* Between near and far the geometry color will be interpolated between the unfogged color and the supplied fog color.

	// Fog far is expected to be at most 1000 so near >= far. Set a constant shade alpha of 0 for no fog
	// Set a constant shade alpha of 0 for no fog

		} else if (near < 0) {
		// Fog near is out of range. Set a constant shade alpha of 255 for fully fogged

	// Fog near is out of range. Set a constant shade alpha of 255 for fully fogged
	// Set a constant shade alpha of 255 for fully fogged

		//! @bug If the difference between near and far is not at least 4, the fog multiplier will overflow. This is
		//! handled above when fog far is 1000 but for closer fog far it is not accounted for.

-        //! @bug If the difference between near and far is not at least 4, the fog multiplier will overflow. This is
-        //! handled above when fog far is 1000 but for closer fog far it is not accounted for.
+        //! @bug If far - near < 4, the computed `fm` fog factor coefficient will overflow.
+        //! For example: 128000 / (983 - 980) > 32767
+        //! This is handled above in the case of near > 996, but the general case is not accounted for.

Document fog functions Gfx_SetFog(2) and Play_SetFog #1922

Are you sure you want to change the base?

Document fog functions Gfx_SetFog(2) and Play_SetFog #1922

Conversation

Thar0 commented Mar 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dragorn421 Mar 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dragorn421 Mar 10, 2024 •

edited

Loading