Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document EnGo and EnGo2 functions, fields, and animations #2295

Open
wants to merge 64 commits into
base: main
Choose a base branch
from
Open

Document EnGo and EnGo2 functions, fields, and animations #2295

wants to merge 64 commits into from
+886 −768

Commits on Nov 11, 2024

  1. Document func_8002F368 as Player_GetExchangeItemId

    @Feacur
    Feacur committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    d3eedf6 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Document Goron's limbs

    @Feacur
    Feacur committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    f249068 View commit details
    Browse the repository at this point in the history

  2. Document Goron's limbs' display lists

    @Feacur
    Feacur committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    a71747b View commit details
    Browse the repository at this point in the history

  3. Document non-limb display lists

    @Feacur
    Feacur committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b3b6b28 View commit details
    Browse the repository at this point in the history

  4. just align attributes

    @Feacur
    Feacur committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    ba0bb10 View commit details
    Browse the repository at this point in the history

  5. Document animations

    @Feacur
    Feacur committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    40203d0 View commit details
    Browse the repository at this point in the history

  6. remove unused EnGo callbacks 

    - `callback1_80A3ED24` is `NpcGetTextIdFunc`
- `callback2_80A3ED24` is `NpcUpdateTalkStateFunc`
    @Feacur
    Feacur committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    60b8664 View commit details
    Browse the repository at this point in the history

  7. redocument EnGo subtypes as an enum

    @Feacur
    Feacur committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    3411f1e View commit details
    Browse the repository at this point in the history

  8. Document EnGo path param

    @Feacur
    Feacur committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    687e70e View commit details
    Browse the repository at this point in the history

  9. Document EnGo opening Goron's cage

    @Feacur
    Feacur committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    78d0d41 View commit details
    Browse the repository at this point in the history

  10. Document func_80A3F0E4 as EnGo_UpdateBlinking 

    reason: `EnGo2_EyeMouthTexState` code analogy
    @Feacur
    Feacur committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    8784c81 View commit details
    Browse the repository at this point in the history

  11. streamline EnGo *_Draw function into 3 sections 

    returns are indeed required to match
    @Feacur
    Feacur committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    46a13d5 View commit details
    Browse the repository at this point in the history

  12. Document bouncing in EnGo_IsRollingOnGround

    @Feacur
    Feacur committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    bbf4225 View commit details
    Browse the repository at this point in the history

  13. Document EnGo .unk_218 as .waypoint

    @Feacur
    Feacur committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    3be6be5 View commit details
    Browse the repository at this point in the history

  14. Document EnGo .unk_20E as .knockbackCooldown

    @Feacur
    Feacur committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    87097be View commit details
    Browse the repository at this point in the history

  15. Document EnGo .unk_212 as .attentionCooldown

    @Feacur
    Feacur committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    9de2038 View commit details
    Browse the repository at this point in the history

  16. Document EnGo .unk_21E as .eyedropsTimer

    @Feacur
    Feacur committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    91d1382 View commit details
    Browse the repository at this point in the history

  17. Document EnGo .unk_210 as .curledTimer

    @Feacur
    Feacur committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    705ff1b View commit details
    Browse the repository at this point in the history

  18. Document EnGo .unk_20C as .gaveSword

    @Feacur
    Feacur committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    8fb7fc2 View commit details
    Browse the repository at this point in the history

  19. EnGo_IsCameraModified -> EnGo_IsAttentionDrawn

    @Feacur
    Feacur committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    4a793fa View commit details
    Browse the repository at this point in the history

  20. Document EnGo play speed factor

    @Feacur
    Feacur committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    c794de2 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Document EnGo funtions based on the context

    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d9bd40d View commit details
    Browse the repository at this point in the history

  2. prepare EnGo2's *_Draw function

    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    686f367 View commit details
    Browse the repository at this point in the history

  3. Document bouncing in EnGo2_IsRollingOnGround

    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    2cc0e12 View commit details
    Browse the repository at this point in the history

  4. Document EnGo2 .unk_211 as .isUncurled

    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    4ecd12d View commit details
    Browse the repository at this point in the history

  5. Document EnGo2 .unk_216 as .reverseWaypoint

    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    50d3b84 View commit details
    Browse the repository at this point in the history

  6. redocument EnGo2 message states

    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    7f30ab6 View commit details
    Browse the repository at this point in the history

  7. move EnGo2 .goronState comments to the TU 

    partially they already were there
    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    960c8b5 View commit details
    Browse the repository at this point in the history

  8. redocument EnGo2 .alpha as .shadowAlpha 

    and `func_80A45360` as `EnGo2_UpdateShadowAlpha`
    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    3b0e2ce View commit details
    Browse the repository at this point in the history

  9. EnGo2_IsCameraModified->EnGo2_IsAttentionDrawn

    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    787b260 View commit details
    Browse the repository at this point in the history

  10. redocument EnGo2 subtypes as an enum

    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    7510ed0 View commit details
    Browse the repository at this point in the history

  11. Document EnGo2 path param

    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    98afe53 View commit details
    Browse the repository at this point in the history

  12. Document EnGo2 opening Goron's cage

    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    9be708d View commit details
    Browse the repository at this point in the history

  13. Document EnGo2 known data

    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    fc1009a View commit details
    Browse the repository at this point in the history

  14. Document EnGo2 funtions based on the context

    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    b908614 View commit details
    Browse the repository at this point in the history

  15. rematch EnGo2_StopRolling

    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    41b9cd0 View commit details
    Browse the repository at this point in the history

  16. unify EnGo2 waking up naming

    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    dbe0a46 View commit details
    Browse the repository at this point in the history

  17. Document func_80A44790 as EnGo2_UpdateTalking 

    rename `.isAwake` as `.isTalkative
    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    37569e2 View commit details
    Browse the repository at this point in the history

  18. document focusOffset variables

    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    da79fb4 View commit details
    Browse the repository at this point in the history

  19. rematch EnGo2_UpdateTalking a bit

    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    1c416be View commit details
    Browse the repository at this point in the history

  20. EnGo2_IsCameraModified -> EnGo2_ShouldStay

    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    35d0d71 View commit details
    Browse the repository at this point in the history

  21. rename func_80A408D8 -> EnGo_AttentionLost

    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    7c1d6f5 View commit details
    Browse the repository at this point in the history

  22. give better names to the attention switching funcs

    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    17d5b2a View commit details
    Browse the repository at this point in the history

  23. give better enum names

    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    7f3642d View commit details
    Browse the repository at this point in the history

  24. rematch EnGo2_RollingSlow

    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    77fde2c View commit details
    Browse the repository at this point in the history

  25. fix a misleading comment

    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    011cf6a View commit details
    Browse the repository at this point in the history

  26. name Hot Rodder consistently 

    zeldaret#2295 (comment)
    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    46648b4 View commit details
    Browse the repository at this point in the history

  27. make the unused comment a header 

    zeldaret#2295 (comment)
    @Feacur
    Feacur committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    9fae0fa View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. document the nature of type values 

    zeldaret#2295 (comment)
    @Feacur
    Feacur committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    57c4c76 View commit details
    Browse the repository at this point in the history

  2. remove unnecessary block braces 

    zeldaret#2295 (comment)
    @Feacur
    Feacur committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    a8dff36 View commit details
    Browse the repository at this point in the history

  3. CAGED_FLAG -> CAGED_SWITCH_FLAG 

    zeldaret#2295 (comment)
    @Feacur
    Feacur committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    e2cda14 View commit details
    Browse the repository at this point in the history

  4. remove a [mis]leading zero

    @Feacur
    Feacur committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    fff6cf4 View commit details
    Browse the repository at this point in the history

  5. remove unnecessary comment 

    zeldaret#2295 (comment)
    @Feacur
    Feacur committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2ab3f6b View commit details
    Browse the repository at this point in the history

  6. use uniform naming between variables 

    zeldaret#2295 (comment)
    @Feacur
    Feacur committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    e87bc05 View commit details
    Browse the repository at this point in the history

  7. tweak EnGo2_UpdateTalking code and comments 

    zeldaret#2295 (comment)
zeldaret#2295 (comment)
zeldaret#2295 (comment)
zeldaret#2295 (comment)
    @Feacur
    Feacur committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    1fa1922 View commit details
    Browse the repository at this point in the history

  8. link two if parts with and else 

    zeldaret#2295 (comment)
    @Feacur
    Feacur committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    9115505 View commit details
    Browse the repository at this point in the history

  9. Document actor.params bits allocation

    @Feacur
    Feacur committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    57951ed View commit details
    Browse the repository at this point in the history

  10. Document actor.params bits allocation 

    an "ammendment" for 57951ed

somehow haven't saved the changes that time
    @Feacur
    Feacur committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    4063499 View commit details
    Browse the repository at this point in the history

  11. yeah, be less judgemental

    @Feacur
    Feacur committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d891107 View commit details
    Browse the repository at this point in the history

  12. clarify "in range" of what it is

    @Feacur
    Feacur committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    768297f View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. use BINANG macros instead of hex values

    @Feacur
    Feacur committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    423748a View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. give a function a better name

    @Feacur
    Feacur committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    fe53732 View commit details
    Browse the repository at this point in the history

  2. name animation reversing func as such

    @Feacur
    Feacur committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    5ba85a3 View commit details
    Browse the repository at this point in the history

  3. follow the bugs documentation style guide

    @Feacur
    Feacur committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    5d1bf77 View commit details
    Browse the repository at this point in the history