dAcTbox_c #108
Merged
dAcTbox_c #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robojumper
force-pushed
the
d_a_obj_tbox
branch
from
5c3295c to
8240b23
Compare
| @@ -83,6 +83,9 @@ class dCcD_Unk : public cCcD_Obj, public cCcD_UnkAttr { | |||
|
|
|||
| virtual cCcD_ShapeAttr *GetShapeAttr() override; | |||
|
|
|||
| // Have to bring these in scope. Consider renaming this | |||
| // Set function instead or create an inline? | |||
| using cM3dGUnk::Set; | |||
There was a problem hiding this comment.
Using inlines don’t work, cM3dGLin::Set didn’t like this at least.
Keep with using, .cM3dG::Set, or we could potentially rename something?
|
This is at 92% text, all data matches, 3 functions have very minor issues, |
elijah-thomas774
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.