Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MBL and UBL #2

Conversation

DerAndere1
Copy link

Description

Use probe.use_probing_tool() in MBL and UBL G29.

Requirements

MESH_BED_LEVELING or AUTO_BED_LEVELING_UBL

Benefits

  • change to T0 during MBL to prevent crashes when HOTEND_OFFSET_* of any tool is not 0
  • Unified logic
  • Also, fix MBL with SAFE_BED_LEVELING_START_*

Configurations

None

Related Issues

@thinkyhead
Copy link

What do you think, @zeleps ?

@zeleps
Copy link
Owner

zeleps commented Dec 2, 2022

I've been busy with other things (like work :) ) lately and I haven't had a chance to see this. Lots of catching up to do. Will look into it during the weekend and let you know.

@zeleps
Copy link
Owner

zeleps commented Dec 3, 2022

I see no problem with these changes, but the whole probing tool change feature is broken. Invoking the use_probing_tool() function from within probe_at_point() without a nesting counter causes an unnecessary tool change at every probe.

I'm merging this PR and will look into the issue later.

@zeleps zeleps merged commit e4b757c into zeleps:bugfix-2.1.x-ProbingToolChangingConfig Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants