Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Zellij prints "Bye from Zellij!" instead of "Session detached" after detaching #3798

Open
ilyagr opened this issue Nov 22, 2024 · 1 comment · May be fixed by #3799
Open

Regression: Zellij prints "Bye from Zellij!" instead of "Session detached" after detaching #3798

ilyagr opened this issue Nov 22, 2024 · 1 comment · May be fixed by #3799

Comments

@ilyagr
Copy link

ilyagr commented Nov 22, 2024

Basic information

zellij --version: zellij 0.41.2

stty size: 22 126

uname -av: Darwin macaw.local 23.6.0 Darwin Kernel Version 23.6.0: Thu Sep 12 23:36:12 PDT 2024; root:xnu-10063.141.1.701.1~1/RELEASE_ARM64_T6020 arm64 arm Darwin

2. Issues with the Zellij UI / behavior / crash

I launch zellij setup --clean and press ^O d to detach the session. I get the "Bye from Zellij!" message.

According to b4cf0e7#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR61 and

zellij/zellij-utils/src/ipc.rs

Line 131 in 09689ea

Self::NormalDetached => write!(f, "Session detached"),
, it's supposed to print "Session detached" in this case, so that I can tell that zellij hasn't quit completely.

(I was initially going to file an FR, but then found that the feature I was going to ask for is supposed to be implemented, it's just not working)

zellij attach still works, so I know that it did detach.
@ilyagr
Copy link
Author

ilyagr commented Nov 22, 2024

I did some git bisect-ing, and it seems that this problem appeared in commit 1f0ae94 (that's the "first bad commit")

@ilyagr ilyagr changed the title Zellij prints "Bye from Zellij!" instead of "Session detached" when I'm detaching the session Regression: Zellij prints "Bye from Zellij!" instead of "Session detached" when I'm detaching the session Nov 22, 2024
@ilyagr ilyagr changed the title Regression: Zellij prints "Bye from Zellij!" instead of "Session detached" when I'm detaching the session Regression: Zellij prints "Bye from Zellij!" instead of "Session detached" after detaching Nov 22, 2024
louiswpf added a commit to louiswpf/zellij that referenced this issue Nov 22, 2024
@louiswpf
fix(cli): fix the detach message
f8e0cd4 
Keys are interpreted on the server after commit 5a437b7
("refactor(server): interpret keys on server so they can be rebound").

Since the server exits with "ExitReason::Normal" instead of
"ExitReason::NormalDetached" when detaching a session, the detach
message becomes "Bye from Zellij!" instead of "Session detached".

Correct the exit reason to fix this.

Fixes: zellij-org#3798
@louiswpf louiswpf linked a pull request Nov 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli): fix the detach message louiswpf/zellij
1 participant
@ilyagr