Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support UTF-8 character in tab name and pane name #2102

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Support UTF-8 character in tab name and pane name #2102

merged 2 commits into from
Jan 19, 2023

Conversation

naosense
Copy link
Contributor

To fix #2065 , expand characters in tab name and pane name

@naosense naosense temporarily deployed to cachix January 17, 2023 12:11 — with GitHub Actions Inactive
@naosense naosense temporarily deployed to cachix January 17, 2023 12:12 — with GitHub Actions Inactive
@naosense
Copy link
Contributor Author

@imsnif @jaeheonji could you please review this pr?

@jaeheonji jaeheonji self-requested a review January 18, 2023 06:44
jaeheonji
jaeheonji approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@jaeheonji jaeheonji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jaeheonji jaeheonji merged commit f9a7188 into zellij-org:main Jan 19, 2023
@naosense naosense deleted the expand_chars branch January 19, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeheonji jaeheonji jaeheonji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UTF-8 doesn’t show up in title
2 participants
@naosense @jaeheonji