Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make session-name option in attach command #542

Merged
merged 1 commit into from
May 28, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ mod sessions;
mod tests;

use crate::install::populate_data_dir;
use sessions::{assert_session, assert_session_ne, list_sessions};
use sessions::{assert_session, assert_session_ne, get_active_session, list_sessions};
use std::convert::TryFrom;
use std::process;
use zellij_client::{os_input_output::get_client_os_input, start_client, ClientInfo};
Expand Down Expand Up @@ -54,16 +54,20 @@ pub fn main() {
}
};
if let Some(Command::Sessions(Sessions::Attach {
session_name,
mut session_name,
force,
})) = opts.command.clone()
{
assert_session(&session_name);
if let Some(session) = session_name.as_ref() {
assert_session(session);
} else {
session_name = Some(get_active_session());
}
start_client(
Box::new(os_input),
opts,
config,
ClientInfo::Attach(session_name, force),
ClientInfo::Attach(session_name.unwrap(), force),
);
} else {
let session_name = opts
Expand Down
97 changes: 55 additions & 42 deletions src/sessions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,22 +29,61 @@ fn get_sessions() -> Result<Vec<String>, io::ErrorKind> {
}
}

fn assert_socket(name: &str) -> bool {
let path = &*ZELLIJ_SOCK_DIR.join(name);
match LocalSocketStream::connect(path) {
Ok(stream) => {
IpcSenderWithContext::new(stream).send(ClientToServerMsg::ClientExited);
true
}
Err(e) => {
if e.kind() == io::ErrorKind::ConnectionRefused {
drop(fs::remove_file(path));
false
} else {
true
}
}
}
}

fn print_sessions(sessions: Vec<String>) {
let curr_session = std::env::var("ZELLIJ_SESSION_NAME").unwrap_or_else(|_| "".into());
sessions.iter().for_each(|session| {
let suffix = if curr_session == *session {
" (current)"
} else {
""
};
println!("{}{}", session, suffix);
})
}

pub(crate) fn get_active_session() -> String {
match get_sessions() {
Ok(mut sessions) => {
if sessions.len() == 1 {
return sessions.pop().unwrap();
}
if sessions.is_empty() {
println!("No active zellij sessions found.");
} else {
println!("Please specify the session name to attach to. The following sessions are active:");
print_sessions(sessions);
}
}
Err(e) => eprintln!("Error occured: {:?}", e),
}
process::exit(1);
}

pub(crate) fn list_sessions() {
let exit_code = match get_sessions() {
Ok(sessions) => {
if sessions.is_empty() {
println!("No active zellij sessions found.");
} else {
let curr_session =
std::env::var("ZELLIJ_SESSION_NAME").unwrap_or_else(|_| "".into());
sessions.iter().for_each(|session| {
let suffix = if curr_session == *session {
" (current)"
} else {
""
};
println!("{}{}", session, suffix);
})
print_sessions(sessions);
}
0
}
Expand All @@ -57,53 +96,27 @@ pub(crate) fn list_sessions() {
}

pub(crate) fn assert_session(name: &str) {
let exit_code = match get_sessions() {
match get_sessions() {
Ok(sessions) => {
if sessions.iter().any(|s| s == name) {
return;
}
println!("No session named {:?} found.", name);
0
}
Err(e) => {
eprintln!("Error occured: {:?}", e);
1
}
Err(e) => eprintln!("Error occured: {:?}", e),
};
process::exit(exit_code);
process::exit(1);
}

pub(crate) fn assert_session_ne(name: &str) {
let exit_code = match get_sessions() {
match get_sessions() {
Ok(sessions) => {
if sessions.iter().all(|s| s != name) {
return;
}
println!("Session with name {:?} aleady exists. Use attach command to connect to it or specify a different name.", name);
0
}
Err(e) => {
eprintln!("Error occured: {:?}", e);
1
}
Err(e) => eprintln!("Error occured: {:?}", e),
};
process::exit(exit_code);
}

fn assert_socket(name: &str) -> bool {
let path = &*ZELLIJ_SOCK_DIR.join(name);
match LocalSocketStream::connect(path) {
Ok(stream) => {
IpcSenderWithContext::new(stream).send(ClientToServerMsg::ClientExited);
true
}
Err(e) => {
if e.kind() == io::ErrorKind::ConnectionRefused {
drop(fs::remove_file(path));
false
} else {
true
}
}
}
process::exit(1);
}
3 changes: 1 addition & 2 deletions zellij-server/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ use crate::{
};
use route::route_thread_main;
use zellij_utils::{
channels,
channels::{ChannelWithContext, SenderWithContext},
channels::{self, ChannelWithContext, SenderWithContext},
cli::CliArgs,
errors::{ContextType, ErrorInstruction, ServerContext},
input::{get_mode_info, options::Options},
Expand Down
2 changes: 1 addition & 1 deletion zellij-utils/src/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ pub enum Sessions {
#[structopt(alias = "a")]
Attach {
/// Name of the session to attach to.
session_name: String,
session_name: Option<String>,

/// Force attach- session will detach from the other
/// zellij client (if any) and attach to this.
Expand Down