-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rules js #2091
Conversation
Zemnmez
commented
Feb 3, 2023
- Simplify and abstract build files.
- Simplify and abstract build files.
- Use rules_js and rules_ts.
1. Use BZLMOD for swc 2. Use partial application of swc instead of swc_transpiler
https://docs.aspect.build/guides/rules_js_migration/#translate-your-lockfile-to-pnpm-format-optional Translate your lockfile to pnpm format (optional) rules_js uses the pnpm lockfile to declare dependency versions as well as a deterministic layout for the node_modules tree. The node_modules tree laid out by rules_js should be bug-for-bug compatible with the node_modules tree that pnpm lays out with hoisting disabled (hoist=false set in your .npmrc). We recommend adding hoist=false to your .npmrc so that your node_modules tree outside of Bazel is similar to the node_modules tree that rules_js creates: echo "hoist=false" >> .npmrc See npm_translate_lock documentation for more information on pnpm hoisting.
new list of failures etc:
|
I think a few of these are related to runfiles, which afaik rules_js does not use:
|
0 build time errors?? apparently??? |
okay... looks like one last issue... we need to make it so that puppeteer works. currently, it tries to download chrome and faiils. we need to have it put chrome somewhere as an output. |
fairly sure I can use this https://pptr.dev/browsers-api as a build action to get the right browser. |
actually, I think I can just get it to dump it into its own node_modules folder as the cache dir – i doubt postinstall knows better. |
I really think it's going to work this time. |
FUck |
okay this time I really do think it will work. |
woo!! |