Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Area Markers - Support editing all area markers #676

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Area Markers - Support editing all area markers #676

merged 2 commits into from
Aug 29, 2022

Conversation

mharis001
Copy link
Member

When merged this pull request will:

  • Support editing all area markers (not just those created through the module or context menu action)
    • Uses the marker mission events to track markers and automatically create editable icons for them when they are area markers
    • Handles 3DEN placed and scripted markers
    • Markers can be blacklisted using the array (used by cover_map currently)
  • Use an event based approach for the icon visibility instead of PFH
    • A lot of edge cases but could not get it to break
    • Probably minor performance improvement
  • Hide icons when the the interface is hidden (screenshot mode)
  • Use HashMaps instead of CBA namespaces

@mharis001 mharis001 added the enhancement Improves an existing feature label Aug 19, 2022
@mharis001 mharis001 added this to the 1.13.0 milestone Aug 19, 2022
@mharis001 mharis001 merged commit ce592fc into master Aug 29, 2022
@mharis001 mharis001 deleted the area-markers-improvements branch August 29, 2022 21:15
@Bob-Murphy Bob-Murphy mentioned this pull request May 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kexanone Kexanone Kexanone approved these changes

@neilzar neilzar neilzar approved these changes

Assignees
No one assigned
Labels
enhancement Improves an existing feature
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mharis001 @neilzar @Kexanone