Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visibility - Add during placement only mode and max distance setting #686

Merged
merged 3 commits into from
Dec 3, 2022
Merged

Visibility - Add during placement only mode and max distance setting #686

merged 3 commits into from
Dec 3, 2022

Conversation

mharis001
Copy link
Member

When merged this pull request will:

  • Add "During Placement Only" mode to visibility indicator
  • Add "Max Check Distance" setting - can range from 100 to 5000 m (same as hardcoded limit of lineIntersectsSurfaces command)
  • Improve getPosFromScreen common function with parameter to control whether a flat position is return or just the first intersection
  • Some minor cleanup of the visibility component
  • Close Feature request: Zeus visibility indicator viewdistance and group placement #421

@mharis001 mharis001 added the enhancement Improves an existing feature label Oct 1, 2022
@mharis001 mharis001 added this to the 1.13.0 milestone Oct 1, 2022
@mharis001 mharis001 merged commit 1ee7ccf into master Dec 3, 2022
@mharis001 mharis001 deleted the visibility-improvements branch December 3, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kexanone Kexanone Kexanone approved these changes

@neilzar neilzar neilzar approved these changes

Assignees
No one assigned
Labels
enhancement Improves an existing feature
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Feature request: Zeus visibility indicator viewdistance and group placement
3 participants
@mharis001 @neilzar @Kexanone