Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add settings to toggle attributes #716

Merged
merged 14 commits into from
May 21, 2023
Merged

Add settings to toggle attributes #716

merged 14 commits into from
May 21, 2023

Conversation

ampersand38
Copy link
Member

@ampersand38 ampersand38 commented Mar 16, 2023 •
edited by mharis001
Loading

When merged this pull request will:

@ampersand38 ampersand38 added the enhancement Improves an existing feature label Mar 16, 2023
@ampersand38 ampersand38 mentioned this pull request Mar 16, 2023
Open
@ampersand38 ampersand38 marked this pull request as draft March 16, 2023 19:26
@ampersand38 ampersand38 marked this pull request as ready for review March 16, 2023 19:26
@ampersand38 ampersand38 requested a review from mharis001 April 2, 2023 00:28
@mharis001
Copy link
Member

I like the idea of having settings for enabling/disabling attributes but not sure about limiting it to only certain ones. A more generalized approach (like the faction filter) might be better but I can foresee some weird UX cases with this option for the "sub-attributes menus" and the buttons used to access them.

@ampersand38
Copy link
Member Author

Ah, I was gonna get around to adding the settings to more attributes and see what mharis thought xD
Soon!

@ampersand38
Copy link
Member Author

image
image

Kexanone
Kexanone approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@Kexanone Kexanone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mharis001
mharis001 requested changes Apr 28, 2023
View reviewed changes
addons/attributes/initAttributes.sqf Outdated Show resolved Hide resolved
addons/attributes/stringtable.xml Outdated Show resolved Hide resolved
@ampersand38 ampersand38 requested a review from mharis001 May 20, 2023 19:02
@mharis001 mharis001 added this to the 1.14.0 milestone May 21, 2023
@mharis001
Copy link
Member

I added the remaining attributes/buttons including those in other components. A bit of a mess, but I guess there isn't really a better way.

@mharis001 mharis001 merged commit d8f8579 into zen-mod:master May 21, 2023
@ampersand38 ampersand38 deleted the toggle-attributes-settings branch May 22, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharis001 mharis001 mharis001 approved these changes

@Kexanone Kexanone Kexanone approved these changes

Assignees
No one assigned
Labels
enhancement Improves an existing feature
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Custom Zeus attributes displays to hide certain attributes
3 participants
@ampersand38 @mharis001 @Kexanone