-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in case using real path in windows #19
Comments
Minkbear, can you please get the latest source code of the tool and check if this fix forks for you? |
@slaff I clone you git for my testing. The result of my testing is the same.
Because of strpos($path, '/')!==0 return true.
ref: strpos |
That should fix the issue. @minkbear can you try again on your system? |
Thank for testing it mate! I will close this issue now. Can you please open
|
@minkbear it's a behavior we probably should document and guard against a bit better - but if your scriptsdir in deployment.xml is zp_script, then in deployment.properties the entry should look like: Such that the prefix is the same. Could you test and let me know please? |
@slaff Thank you too. created as #20 |
If pass parameter in windows like this:
--folder="C:\tests"
--destination="C:\tests"
It shows error
The application has thrown an exception!
Zend\ServiceManager\Exception\RuntimeException
The specified directory does not have deployment.xml.
But it is existing deployment.xml at that path.
After that I took a look on the code and met:
PathInvokable.getAbsolute send the result is wrong for example
result from PathInvokable.getAbsolute is
I just finished fix it but unable to pull request only my 1 commit.
Please take a look at minkbear/ZendServerSDK@d27b5ac
The text was updated successfully, but these errors were encountered: