Skip to content

Update t-function to support nested keys. Previous code does not handle nested key access properly #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update t-function to support nested keys. Previous code does not handle nested key access properly #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/react/src/lib/i18n.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,16 @@ class I18n {
const keyType = typeof key
if (keyType !== 'string') throw new Error(`Translation key must be a string, got: ${keyType}`)

const template = this.translations[key]
if (!template) throw new Error(`Missing translation: ${key}`)
// Split the key into parts to support nested keys
const keyParts = key.split('.')
let template = this.translations

// Traverse the translations object to get the final value
for (const part of keyParts) {
template = template[part]
if (!template) throw new Error(`Missing translation: ${key}`)
}

if (typeof template !== 'string') throw new Error(`Invalid translation for key: ${key}`)

return template.replace(/{{(.*?)}}/g, (_, match) => context[match] || '')
Expand Down