Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): set checkout step to not persist credentials #208

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

anpa
Copy link
Contributor

@anpa anpa commented Mar 19, 2020

Description

According to https://github.com/actions/checkout/tree/master#checkout-v2:

The auth token is persisted in the local git config. This enables your scripts to run authenticated git commands. The token is removed during post-job cleanup. Set persist-credentials: false to opt-out.

semantic-release/git#196 also hints that the semantic-release step may be using the auth token set in the checkout step.

This PR sets persist-credentials: false in the checkout step so the semantic-release step can use the token from its configuration.

Checklist

  • 📗 all commit messages follow the conventional commits standard
  • 💅 SASS files are compiled
  • ⬅️ changes are compatible with RTL direction
  • ♿ changes are accessible
  • 📝 changes are tested in Chrome, Firefox, Safari, Edge, and IE11
  • 👍 PR is approved by @zendesk/vikings

@anpa anpa requested a review from a team as a code owner March 19, 2020 14:43
@anpa anpa merged commit 3d4c449 into master Mar 19, 2020
@anpa anpa deleted the andre_fix_release branch March 19, 2020 16:15
@zd-svc-github-copenhagen-theme
Copy link
Collaborator

🎉 This PR is included in version 2.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants