-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a11y: Dropdowns #388
a11y: Dropdowns #388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! When the required api update is ready 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor and tests look good, so no comments there 👍🏼
A couple of points:
- Can we colocate the spec file with the source code?
- Nit: no need to check in
scipt.js
andstyle.css
as these are rebuilt upon every merge.
@luis-almeida okay! I have now moved the test file next to the component |
🎉 This PR is included in version 3.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
This PR refactors the existing dropdown component and aligns it with Navigation Menubar, Menubar, and Menu button
Home
,End
andCharacter
key.aria-controls
andaria-labelledby
as per Menu button spec.aria-expanded
attribute to the toggle as per spec.role=menuitemradio
, to better handle menus where there is an existing selection. It updates the templates as appropiate.The PR also does minor updates to theme to better align with Garden styles.
Screenshots
Checklist