Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Required fields are marked:
required
property on the element (done before this PR)*
The asterisk is explained on the top of the form, as suggested by the design and accessibility team. In the beginning we were considering having the explanation on the first of the required fields but that approach turned out to be too complicated and/or confusing considering the conditional fields, change of order, etc.
I tested this using a Voice Over and the
required
attribute on the input informs that the field is required. Screen readers won’t read the*
symbol.We will need a translation for the explanation string.
Questions
I am not sure if this will behave correctly for RTL languages. I tried to test it on the existing form but I think there is more things missing, for example the labels are not moved to right, etc. But still, I am open to suggestions here!
Screenshots
Checklist