Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added CreditCard field #434

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

Fredx87
Copy link
Contributor

@Fredx87 Fredx87 commented Sep 27, 2023

Description

This PR adds a CreditCard field, which redacts the credit card number on blur. The redaction happens also when the form is submitted, to ensure that the number is redacted even if the input was not blurred (for example, pressing ENTER on the Credit Card field will submit the form without blurring the input).

The redaction logic is ported from the library used in Help Center.

Screenshots

Screen.Recording.2023-09-27.at.10.07.15.mov

Checklist

  • 📗 all commit messages follow the conventional commits standard
  • ⬅️ changes are compatible with RTL direction
  • ♿ Changes to the UI are tested for accessibility and compliant with WCAG 2.1.
  • 📝 changes are tested in Chrome, Firefox, Safari and Edge
  • 📱 changes are responsive and tested in mobile
  • 👍 PR is approved by @zendesk/vikings

@Fredx87 Fredx87 requested a review from a team as a code owner September 27, 2023 08:18
Copy link
Contributor

@anpa anpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👏

@Fredx87 Fredx87 merged commit 9eda655 into v4-alpha Sep 27, 2023
@Fredx87 Fredx87 deleted the gianluca/credit-card-redaction branch September 27, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants