Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service catalog core pages #538

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

gosiexon-zen
Copy link
Contributor

@gosiexon-zen gosiexon-zen commented Oct 31, 2024

Description

We were using custom pages in Copenhagen Theme to quickly start implementation of SC. Target solution is to have core pages. Now when we have backend ready we can move from custom pages.
We are still mocking data for single service item - this will be resolved inn the next PR
Jira issue

Screenshots

Checklist

  • 📗 all commit messages follow the conventional commits standard
  • ⬅️ changes are compatible with RTL direction
  • ♿ Changes to the UI are tested for accessibility and compliant with WCAG 2.1.
  • 📝 changes are tested in Chrome, Firefox, Safari and Edge
  • 📱 changes are responsive and tested in mobile
  • 👍 PR is approved by @zendesk/vikings

@gosiexon-zen gosiexon-zen force-pushed the mbien/service-catalog-core-pages branch 2 times, most recently from bf36282 to 219d2c9 Compare November 13, 2024 12:25
@gosiexon-zen gosiexon-zen force-pushed the mbien/service-catalog-core-pages branch from 23b339d to 5bc1500 Compare November 13, 2024 12:48
@gosiexon-zen gosiexon-zen marked this pull request as ready for review November 13, 2024 12:49
@gosiexon-zen gosiexon-zen requested a review from a team as a code owner November 13, 2024 12:49
@gosiexon-zen gosiexon-zen merged commit 30dcab4 into service-catalog-eap Nov 14, 2024
5 checks passed
@gosiexon-zen gosiexon-zen deleted the mbien/service-catalog-core-pages branch November 14, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants