Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new string for translations #553

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

gosiexon-zen
Copy link
Contributor

Description

Added ErrorBoundary component with default error screen so we need translations for it.

Screenshots

Screenshot 2024-12-11 at 11 09 24

Checklist

  • 📗 all commit messages follow the conventional commits standard
  • ⬅️ changes are compatible with RTL direction
  • ♿ Changes to the UI are tested for accessibility and compliant with WCAG 2.1.
  • 📝 changes are tested in Chrome, Firefox, Safari and Edge
  • 📱 changes are responsive and tested in mobile
  • 👍 PR is approved by @zendesk/vikings

@gosiexon-zen gosiexon-zen requested a review from a team as a code owner December 11, 2024 12:33
key: "cph-theme-error-boundary.go-to-homepage"
title: "Error state go to the homepage link"
screenshot: "https://drive.google.com/file/d/1rJ9c4mW0YWnL5d6KWWZaY9TJBEH5otLL/view?usp=drive_link"
value: "Go to the homepage"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nitpick) As mentioned in the other PR, we usually add a newline at the end of the files. To keep everything consistent we should do it here as well.

Copy link

@kubraokcu kubraokcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼🌐

@kubraokcu kubraokcu added the g11n-approved Commented by Globalization label label Dec 11, 2024
@gosiexon-zen gosiexon-zen force-pushed the mbien/new-translation-strings branch from 315cd86 to 6fa919d Compare December 11, 2024 14:52
@gosiexon-zen gosiexon-zen merged commit 6840432 into master Dec 16, 2024
5 checks passed
@gosiexon-zen gosiexon-zen deleted the mbien/new-translation-strings branch December 16, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
g11n-approved Commented by Globalization label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants