replaces error log with event emission when not connected to redis

zendesk · Feb 28, 2020 · 3de9832 · 3de9832
1 parent 0bd5eea
commit 3de9832
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/lib/persistence.js b/lib/persistence.js
@@ -1,12 +1,15 @@
 var logging = require('minilog')('persistence'),
     ConnectionHelper = require('./connection_helper.js'),
+    EventEmitter = require('events'),
     // defaults
     connection = {},
     connected = false,
     connecting = false,
     configuration = {};
 
-const Persistence = { }
+const Persistence = {
+  emitter: new EventEmitter()
+};
 
 Persistence.connect = function(done) {
   if (!connected) {
@@ -33,7 +36,7 @@ Persistence.redis = function(value) {
     connection.client = value;
   }
   if(!connection.client || connection.subscriber.status !== 'ready') {
-    logging.error('Client: Not connected to redis');
+    this.emitter.emit('clientNotConnected');
   }
   return connection.client;
 };
@@ -43,7 +46,7 @@ Persistence.pubsub = function(value) {
     connection.subscriber = value;
   }
   if(!connection.subscriber || connection.subscriber.status !== 'ready') {
-    logging.error('Pubsub: Not connected to redis');
+    this.emitter.emit('pubsubNotConnected');
   }
   return connection.subscriber;
 };

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -27,6 +27,6 @@
     "glob": "7.0.5"
   },
   "dependencies": {
-    "ioredis": "^4.14.1"
+    "ioredis": "^4.16.0"
   }
 }